Skip to content

feat: SDK update for version 29.2.0 - #172

Merged
ChiragAgg5k merged 1 commit into
29.xfrom
release-29.2.0
Oct 9, 2026
Merged

ChiragAgg5k merged 1 commit into
29.xfrom
release-29.2.0

Conversation

@ChiragAgg5k

Copy link
Copy Markdown
Member

This PR contains updates to the SDK for version 29.2.0.

What's Changed

  • Added: optional interval parameter on functions.create and functions.update to run a function every N minutes
  • Added: interval on the Function model and functionsIntervalMinimum on the BillingPlan model

@hansi-codes

hansi-codes Bot commented Oct 9, 2026

Copy link
Copy Markdown

🔵 Tier A · Mergeable after minor fixes

The PR is mergeable after correcting the scheduling examples and adding coverage for the new request field.

This SDK update adds the optional interval parameter to function creation and updates, and exposes interval-related fields on the Function and BillingPlan models. It also updates the package and client version identifiers and adds interval to the function examples and changelog.

Verdict New comments Fixed Still open
✅ Approved 2 0 0
Finding Where
🟡 Examples combine mutually exclusive scheduling fields docs/examples/functions/create.md:34
🟡 Add coverage for interval serialization src/services/functions.ts:452
Fix with agent prompt
### Issue 1
docs/examples/functions/create.md:34
**Examples combine mutually exclusive scheduling fields**

This example still sets `schedule` to a CRON expression above, so copying it sends `schedule` together with `interval: 0`, which the API documentation says cannot be combined. The update example has the same conflict; please show only one scheduling option in each example.

### Issue 2
src/services/functions.ts:452-454
**Add coverage for interval serialization**

The existing create/update tests in `test/services/functions.test.js` only check returned data and do not assert request payloads, so they would pass if `interval` were omitted or mapped incorrectly. Please cover interval serialization for the new API parameter, including the positional overload if it remains supported.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
📂 Walkthrough · 6
File Change
CHANGELOG.md Documents the 29.2.0 SDK additions.
docs/examples/functions/create.md, docs/examples/functions/update.md Adds interval to the function create and update examples.
package.json, package-lock.json Updates the package version to 29.2.0.
src/client.ts Updates the SDK version in the user agent and request headers.
src/models.ts Adds interval to Function and functionsIntervalMinimum to BillingPlan.
src/services/functions.ts Adds interval to create/update typings, positional overloads, and request payloads.

Reviewed f631452 · Details · Comment @hansi-codes review to re-run, or mention @hansi-codes with a question.

@hansi-codes hansi-codes Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Tier A · Looks good to merge. Summary

buildSpecification: 's-1vcpu-512mb', // optional
runtimeSpecification: 's-1vcpu-512mb', // optional
deploymentRetention: 0, // optional
interval: 0, // optional

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Examples combine mutually exclusive scheduling fields

This example still sets schedule to a CRON expression above, so copying it sends schedule together with interval: 0, which the API documentation says cannot be combined. The update example has the same conflict; please show only one scheduling option in each example.

Prompt To Fix With AI
This is a comment left during a code review.
Path: docs/examples/functions/create.md
Line: 34

Comment:
**Examples combine mutually exclusive scheduling fields**

This example still sets `schedule` to a CRON expression above, so copying it sends `schedule` together with `interval: 0`, which the API documentation says cannot be combined. The update example has the same conflict; please show only one scheduling option in each example.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

🟡 Minor · documentation · Reply if this doesn't apply.

Comment thread src/services/functions.ts
Comment on lines +452 to +454
if (typeof interval !== 'undefined') {
apiPayload['interval'] = interval;
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add coverage for interval serialization

The existing create/update tests in test/services/functions.test.js only check returned data and do not assert request payloads, so they would pass if interval were omitted or mapped incorrectly. Please cover interval serialization for the new API parameter, including the positional overload if it remains supported.

Prompt To Fix With AI
This is a comment left during a code review.
Path: src/services/functions.ts
Line: 452-454

Comment:
**Add coverage for interval serialization**

The existing create/update tests in `test/services/functions.test.js` only check returned data and do not assert request payloads, so they would pass if `interval` were omitted or mapped incorrectly. Please cover interval serialization for the new API parameter, including the positional overload if it remains supported.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

🟡 Minor · testing · Reply if this doesn't apply.

@ChiragAgg5k
ChiragAgg5k merged commit 7e66ac1 into 29.x Oct 9, 2026
2 checks passed
@ChiragAgg5k
ChiragAgg5k deleted the release-29.2.0 branch October 9, 2026 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant