Repository navigation
feat: SDK update for version 29.2.0 - #172
Conversation
🔵 Tier A · Mergeable after minor fixes
This SDK update adds the optional interval parameter to function creation and updates, and exposes interval-related fields on the Function and BillingPlan models. It also updates the package and client version identifiers and adds interval to the function examples and changelog.
Fix with agent prompt### Issue 1
docs/examples/functions/create.md:34
**Examples combine mutually exclusive scheduling fields**
This example still sets `schedule` to a CRON expression above, so copying it sends `schedule` together with `interval: 0`, which the API documentation says cannot be combined. The update example has the same conflict; please show only one scheduling option in each example.
### Issue 2
src/services/functions.ts:452-454
**Add coverage for interval serialization**
The existing create/update tests in `test/services/functions.test.js` only check returned data and do not assert request payloads, so they would pass if `interval` were omitted or mapped incorrectly. Please cover interval serialization for the new API parameter, including the positional overload if it remains supported.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.📂 Walkthrough · 6
Reviewed |
| buildSpecification: 's-1vcpu-512mb', // optional | ||
| runtimeSpecification: 's-1vcpu-512mb', // optional | ||
| deploymentRetention: 0, // optional | ||
| interval: 0, // optional |
There was a problem hiding this comment.
Examples combine mutually exclusive scheduling fields
This example still sets schedule to a CRON expression above, so copying it sends schedule together with interval: 0, which the API documentation says cannot be combined. The update example has the same conflict; please show only one scheduling option in each example.
Prompt To Fix With AI
This is a comment left during a code review.
Path: docs/examples/functions/create.md
Line: 34
Comment:
**Examples combine mutually exclusive scheduling fields**
This example still sets `schedule` to a CRON expression above, so copying it sends `schedule` together with `interval: 0`, which the API documentation says cannot be combined. The update example has the same conflict; please show only one scheduling option in each example.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.🟡 Minor · documentation · Reply if this doesn't apply.
| if (typeof interval !== 'undefined') { | ||
| apiPayload['interval'] = interval; | ||
| } |
There was a problem hiding this comment.
Add coverage for interval serialization
The existing create/update tests in test/services/functions.test.js only check returned data and do not assert request payloads, so they would pass if interval were omitted or mapped incorrectly. Please cover interval serialization for the new API parameter, including the positional overload if it remains supported.
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/services/functions.ts
Line: 452-454
Comment:
**Add coverage for interval serialization**
The existing create/update tests in `test/services/functions.test.js` only check returned data and do not assert request payloads, so they would pass if `interval` were omitted or mapped incorrectly. Please cover interval serialization for the new API parameter, including the positional overload if it remains supported.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.🟡 Minor · testing · Reply if this doesn't apply.
This PR contains updates to the SDK for version 29.2.0.
What's Changed
intervalparameter onfunctions.createandfunctions.updateto run a function every N minutesintervalon theFunctionmodel andfunctionsIntervalMinimumon theBillingPlanmodel