Skip to content

feat: SDK update for version 30.2.0 - #88

Merged
ChiragAgg5k merged 1 commit into
mainfrom
release/30.2.0
Oct 9, 2026
Merged

ChiragAgg5k merged 1 commit into
mainfrom
release/30.2.0

Conversation

@ChiragAgg5k

Copy link
Copy Markdown
Member

This PR contains updates to the SDK for version 30.2.0.

What's Changed

  • Added: optional interval parameter on functions.create and functions.update to run a function every N minutes
  • Added: interval on the Function model and functionsIntervalMinimum on the BillingPlan model

@hansi-codes

hansi-codes Bot commented Oct 9, 2026

Copy link
Copy Markdown

🔵 Tier A · Mergeable after minor fixes

The implementation has one minor test-coverage gap for the new request parameter.

This SDK update adds function interval scheduling parameters, exposes interval data on Function models, and adds the minimum supported interval to BillingPlan models. It also updates the version metadata and documents the new scheduling option.

Verdict New comments Fixed Still open
✅ Approved 1 0 0
Finding Where
🟡 Test interval request serialization src/Appwrite/Services/Functions.php:163
Fix with agent prompt
### Issue 1
src/Appwrite/Services/Functions.php:163-165
**Test interval request serialization**

The new interval parameter has no coverage in `FunctionsTest`; its create/update tests accept any request arguments and only assert the response model type. Those tests would still pass if this field were dropped or sent incorrectly, so please add an assertion for the interval in the request parameters.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
📂 Walkthrough · 9
File Change
CHANGELOG.md Records the SDK 30.2.0 additions.
docs/examples/functions/create.md Adds the optional interval argument to the create example.
docs/examples/functions/update.md Adds the optional interval argument to the update example.
docs/functions.md Documents interval support and its interaction with schedule.
src/Appwrite/Client.php Updates the SDK version in request headers.
src/Appwrite/Models/BillingPlan.php Hydrates and serializes the plan's minimum function interval.
src/Appwrite/Models/FunctionModel.php Adds the nullable interval field to function models.
src/Appwrite/Services/Functions.php Adds interval arguments to function creation and update requests.
tests/Appwrite/Services/OrganizationTest.php Adds the interval minimum to BillingPlan response fixtures.

Reviewed 57e5bf8 · Details · Comment @hansi-codes review to re-run, or mention @hansi-codes with a question.

@hansi-codes hansi-codes Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Tier A · Looks good to merge. Summary

Comment on lines +163 to +165
if (!is_null($interval)) {
$apiParams['interval'] = $interval;
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test interval request serialization

The new interval parameter has no coverage in FunctionsTest; its create/update tests accept any request arguments and only assert the response model type. Those tests would still pass if this field were dropped or sent incorrectly, so please add an assertion for the interval in the request parameters.

Prompt To Fix With AI
This is a comment left during a code review.
Path: src/Appwrite/Services/Functions.php
Line: 163-165

Comment:
**Test interval request serialization**

The new interval parameter has no coverage in `FunctionsTest`; its create/update tests accept any request arguments and only assert the response model type. Those tests would still pass if this field were dropped or sent incorrectly, so please add an assertion for the interval in the request parameters.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

🟡 Minor · testing · Reply if this doesn't apply.

@ChiragAgg5k
ChiragAgg5k merged commit 5c7f16d into main Oct 9, 2026
2 checks passed
@ChiragAgg5k
ChiragAgg5k deleted the release/30.2.0 branch October 9, 2026 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant