Skip to content

fix: cap tokio-util below 0.7.20 to keep the 1.83 MSRV - #32

Merged
ChiragAgg5k merged 1 commit into
mainfrom
fix/tokio-util-msrv
Oct 9, 2026
Merged

ChiragAgg5k merged 1 commit into
mainfrom
fix/tokio-util-msrv

Conversation

@ChiragAgg5k

@ChiragAgg5k ChiragAgg5k commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

The 0.16.0 publish to crates.io failed because tokio-util 0.7.20, pulled in through tokio/reqwest, requires rustc 1.85, while the crate declares rust-version = "1.83" and the publish workflow builds with 1.83: https://github.com/appwrite/sdk-for-rust/actions/workflows/publish.yml

This caps it below 0.7.20, the same way hyper-util, indexmap and url are already capped. cargo +1.83.0 test --all-features passes (750 tests) and cargo publish --dry-run succeeds with a fresh lockfile.

0.16.0 is not on crates.io yet, so once this merges the publish workflow can be run from main to publish 0.16.0.

Related: appwrite/sdk-generator#2002

@hansi-codes

hansi-codes Bot commented Oct 9, 2026

Copy link
Copy Markdown

🟢 Tier S · Ready to merge

The change is a focused dependency constraint with no identified behavior or compatibility issue.

Adds a direct tokio-util version constraint capped below 0.7.20. This keeps dependency resolution within the Rust 1.83 compatibility range described in the PR.

Verdict New comments Fixed Still open
✅ Approved 0 0 0
📂 Walkthrough · 1
File Change
Cargo.toml Adds the tokio-util version cap.

Reviewed f5480c9 · Details · Comment @hansi-codes review to re-run, or mention @hansi-codes with a question.

@hansi-codes hansi-codes Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Tier S · Looks good to merge. Summary

@ChiragAgg5k
ChiragAgg5k merged commit ce4f52d into main Oct 9, 2026
2 checks passed
@ChiragAgg5k
ChiragAgg5k deleted the fix/tokio-util-msrv branch October 9, 2026 13:36
@ChiragAgg5k ChiragAgg5k self-assigned this Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant