Repository navigation
feat: API specs update for version 2.3.x - #119
Conversation
|
| OAuthProvider.AMAZON, // provider | ||
| "https://example.com", // success (optional) | ||
| "https://example.com", // failure (optional) | ||
| List.of(), // scopes (optional) |
There was a problem hiding this comment.
Missing Java Collection Imports
This snippet calls List.of() but does not import java.util.List, so copying it into a Java or Android project fails to compile with an unresolved symbol. The same generator issue affects 266 new Java examples, including examples that use Map.of() without importing java.util.Map; please update the generator templates to emit the required imports.
Prompt To Fix With AI
This is a comment left during a code review.
Path: examples/2.3.x/client-android/java/account/create-o-auth-2-session.md
Line: 19
Comment:
**Missing Java Collection Imports**
This snippet calls `List.of()` but does not import `java.util.List`, so copying it into a Java or Android project fails to compile with an unresolved symbol. The same generator issue affects 266 new Java examples, including examples that use `Map.of()` without importing `java.util.Map`; please update the generator templates to emit the required imports.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.There was a problem hiding this comment.
Valid, but not new in 2.3.x: the published 2.2.x Java examples have the same missing java.util imports at about the same rate (123 vs 120 in a 400-file sample). The examples come from the sdk-generator Java templates, so the fix belongs there and will land in every version on the next regeneration. Not blocking this release.
This PR contains API specification updates for version 2.3.x.