Skip to content

feat: API specs update for version 2.4.x - #127

Merged
ChiragAgg5k merged 1 commit into
mainfrom
feat-2.4.x-specs
Oct 8, 2026
Merged

ChiragAgg5k merged 1 commit into
mainfrom
feat-2.4.x-specs

Conversation

@ChiragAgg5k

Copy link
Copy Markdown
Member

This PR contains API specification updates and SDK examples for version 2.4.x.

@ChiragAgg5k
ChiragAgg5k merged commit 98cc1a2 into main Oct 8, 2026
2 checks passed
@hansi-codes

hansi-codes Bot commented Oct 8, 2026

Copy link
Copy Markdown

🔵 Tier A · Mergeable after minor fixes

The PR has two minor issues that leave some generated SDK examples uncompilable.

This PR refreshes the 2.4.x OpenAPI specifications and updates SDK examples, including OAuth2 resource parameters and Flutter model references. It also adds Console CLI examples for Advisor and database services.

1047 of 1325 changed files were too large to include in full.

Verdict New comments Fixed Still open
💬 Commented 2 0 0

Note

Not approving while a bug finding is open: Java OAuth2 examples use List without importing it

Finding Where
🟡 Java OAuth2 examples use List without importing it examples/2.4.x/client-android/java/oauth2/authorize.md:26
🟡 Flutter snippets emit an invalid models. result declaration examples/2.4.x/client-flutter/examples/analytics/create-event.md:10
Fix with agent prompt
### Issue 1
examples/2.4.x/client-android/java/oauth2/authorize.md:26
**Java OAuth2 examples use List without importing it**

This call now uses `List.of()`, but the snippet does not import `java.util.List`, so it will not compile. The same missing import affects the other modified Java OAuth2 examples that now pass `List.of()` for `resource`.

### Issue 2
examples/2.4.x/client-flutter/examples/analytics/create-event.md:10
**Flutter snippets emit an invalid models. result declaration**

`models. result` is not valid Dart syntax, so this example cannot be compiled. The same malformed declaration appears in the modified Flutter OAuth2 `logout`, `logout-post`, and `revoke` examples, which also do not import `models`.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
📂 Walkthrough · 3
File Change
specs/2.4.x/open-api3-2.4.x*.json Update the 2.4.x OpenAPI specifications.
examples/2.4.x/client-* Update OAuth2 resource arguments across SDK examples and qualify Flutter model return types.
examples/2.4.x/console-cli/examples/{advisor,mongo,mysql,postgresql} Add Console CLI examples for Advisor reports and database operations.

Reviewed 98d06f5 · Details · Comment @hansi-codes review to re-run, or mention @hansi-codes with a question.

@hansi-codes hansi-codes Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Tier A · See the inline comments. Summary

0L, // max_age (optional)
"<AUTHORIZATION_DETAILS>", // authorization_details (optional)
"", // resource (optional)
List.of(), // resource (optional)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Java OAuth2 examples use List without importing it

This call now uses List.of(), but the snippet does not import java.util.List, so it will not compile. The same missing import affects the other modified Java OAuth2 examples that now pass List.of() for resource.

Prompt To Fix With AI
This is a comment left during a code review.
Path: examples/2.4.x/client-android/java/oauth2/authorize.md
Line: 26

Comment:
**Java OAuth2 examples use List without importing it**

This call now uses `List.of()`, but the snippet does not import `java.util.List`, so it will not compile. The same missing import affects the other modified Java OAuth2 examples that now pass `List.of()` for `resource`.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

🟡 Minor · bug · Reply if this doesn't apply.

Analytics analytics = Analytics(client);

result = await analytics.createEvent(
models. result = await analytics.createEvent(

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flutter snippets emit an invalid models. result declaration

models. result is not valid Dart syntax, so this example cannot be compiled. The same malformed declaration appears in the modified Flutter OAuth2 logout, logout-post, and revoke examples, which also do not import models.

Prompt To Fix With AI
This is a comment left during a code review.
Path: examples/2.4.x/client-flutter/examples/analytics/create-event.md
Line: 10

Comment:
**Flutter snippets emit an invalid models. result declaration**

`models. result` is not valid Dart syntax, so this example cannot be compiled. The same malformed declaration appears in the modified Flutter OAuth2 `logout`, `logout-post`, and `revoke` examples, which also do not import `models`.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

🟡 Minor · bug · Reply if this doesn't apply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant