Repository navigation
feat: API specs update for version 2.4.x - #127
Conversation
…lists and WAF rule unions
🔵 Tier A · Mergeable after minor fixes
This PR refreshes the 2.4.x OpenAPI specifications and updates SDK examples, including OAuth2 resource parameters and Flutter model references. It also adds Console CLI examples for Advisor and database services. 1047 of 1325 changed files were too large to include in full.
Note Not approving while a bug finding is open: Java OAuth2 examples use List without importing it
Fix with agent prompt### Issue 1
examples/2.4.x/client-android/java/oauth2/authorize.md:26
**Java OAuth2 examples use List without importing it**
This call now uses `List.of()`, but the snippet does not import `java.util.List`, so it will not compile. The same missing import affects the other modified Java OAuth2 examples that now pass `List.of()` for `resource`.
### Issue 2
examples/2.4.x/client-flutter/examples/analytics/create-event.md:10
**Flutter snippets emit an invalid models. result declaration**
`models. result` is not valid Dart syntax, so this example cannot be compiled. The same malformed declaration appears in the modified Flutter OAuth2 `logout`, `logout-post`, and `revoke` examples, which also do not import `models`.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.📂 Walkthrough · 3
Reviewed |
| 0L, // max_age (optional) | ||
| "<AUTHORIZATION_DETAILS>", // authorization_details (optional) | ||
| "", // resource (optional) | ||
| List.of(), // resource (optional) |
There was a problem hiding this comment.
Java OAuth2 examples use List without importing it
This call now uses List.of(), but the snippet does not import java.util.List, so it will not compile. The same missing import affects the other modified Java OAuth2 examples that now pass List.of() for resource.
Prompt To Fix With AI
This is a comment left during a code review.
Path: examples/2.4.x/client-android/java/oauth2/authorize.md
Line: 26
Comment:
**Java OAuth2 examples use List without importing it**
This call now uses `List.of()`, but the snippet does not import `java.util.List`, so it will not compile. The same missing import affects the other modified Java OAuth2 examples that now pass `List.of()` for `resource`.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.🟡 Minor · bug · Reply if this doesn't apply.
| Analytics analytics = Analytics(client); | ||
|
|
||
| result = await analytics.createEvent( | ||
| models. result = await analytics.createEvent( |
There was a problem hiding this comment.
Flutter snippets emit an invalid models. result declaration
models. result is not valid Dart syntax, so this example cannot be compiled. The same malformed declaration appears in the modified Flutter OAuth2 logout, logout-post, and revoke examples, which also do not import models.
Prompt To Fix With AI
This is a comment left during a code review.
Path: examples/2.4.x/client-flutter/examples/analytics/create-event.md
Line: 10
Comment:
**Flutter snippets emit an invalid models. result declaration**
`models. result` is not valid Dart syntax, so this example cannot be compiled. The same malformed declaration appears in the modified Flutter OAuth2 `logout`, `logout-post`, and `revoke` examples, which also do not import `models`.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.🟡 Minor · bug · Reply if this doesn't apply.
This PR contains API specification updates and SDK examples for version 2.4.x.