Conversation
physicsdolphin
added a commit
to Skyworks-Neo/nvapi-rs
that referenced
this pull request
Aug 27, 2026
- #15 QueryInterface fn-pointer cache: AtomicUsize -> AtomicPtr<c_void>; nvapi_QueryInterface now returns *mut c_void (null sentinel instead of magic 0), nvapi! macro transmutes pointer->fn directly — no usize round-trips left on the entry-point path. Examples adapted. - arcnmx#12 NvVersion::new size assert: REJECTED after triage — the >64KiB RE'd mega-structs (pstates V4 / clk-vf-points V3 / power-policies V1) rely on the driver building the same lossy size|ver<<16 dword from its own struct, so truncation compares equal on both sides; assert would fire on hardware-verified paths. Documented the semantics instead; layout drift stays pinned by nvversion! `= size` literals + layout tests. - #16 zeroed(): doc stack-hazard notes on both nvstruct arms (Box::new_zeroed for >=1MiB structs) + #[inline] on the unchecked arm - arcnmx#11 status.rs: module-level doc on the deliberate dual-track design (bare c_int ABI vs typed Status; unknown codes -> NvapiError::raw_status) - arcnmx#9 remainder: NvEnum/NvBits aliases are load-bearing in macro codegen (scout's zero-use claim wrong) — documented instead of removed - hi/: leftover empty stub (hi/.gitignore + empty src/) removed Co-Authored-By: Claude <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed that
set_vfp_tablewas setting twice the deltas.Also, fixes that are needed to run on my 3070Ti Mobile:
NVAPI_ERRORNVAPI_GPU_NOT_POWERED- appears when discrete laptop GPU isn't powered at the moment instead of returning genericNVAPI_ERROR