Repository navigation
feat: turn drive state reading and publishing on in production - #2335
Merged
Merged
Conversation
- prod.json: enableSyncFromDriveState and enableDriveStatePublishing on, as staging has run them since 2026-10-16 - configVersion 3 -> 4, so users who already ran the app take the new config; without the bump their stored config keeps both off - the flag rail test now expects staging and prod on, dev off Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y4dehHVpH2fFgzitCz1yJ6
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 6 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Visit the preview URL for this PR (updated for commit a6de179): https://ardrive-web--pr2335-prod-drive-state-on-874shhf1.web.app (expires Wed, 28 Oct 2026 01:41:16 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a224ebaee2f0939e7665e7630e7d3d6cd7d0f8b0 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns Drive State on in production for this release, as staging has run it since 2026-10-16.
Change
assets/config/prod.json:enableSyncFromDriveStateandenableDriveStatePublishingset totrue, the same as staging.configVersiongoes from 3 to 4. Without the bump, anyone who has already run the app keeps their stored config, with both switches off (ConfigFetcherreplaces the stored config only when the asset'sconfigVersionis higher).drive_state_publishing_rail_test.dartnow expects staging and prod on, and dev off.What users get
Side effect of the
configVersionbumpReplacing the stored config resets every setting a user changed in the app back to the asset defaults:
arweaveGatewayUrl);arweaveGatewayForDataRequest), because detection runs only when there is no stored config at all;The bump in #2200 (August 27) had the same effect. A follow-up could carry a user's own choices across a version bump.
Checks
test/drive_state/drive_state_publishing_rail_test.dartandtest/services/config: 46 pass.🤖 Generated with Claude Code
https://claude.ai/code/session_01Y4dehHVpH2fFgzitCz1yJ6