Add *= and /= compound assignment sugar (and extended tests) - #537
Open
axic wants to merge 1 commit into
Open
Conversation
The `*` / `/` operators (ExpTimes / ExpDivide, backed by the Mul / Div classes) already exist, but the matching compound assignments were missing while `+= -= ^= &= |= %=` were all present. Add `*=` and `/=` so every binary arithmetic/bitwise operator has a compound assignment, desugaring `lhs *= rhs` to `lhs := lhs * rhs` (and likewise for `/=`), mirroring the existing `%=` sugar. Guard the `*` and `/` infix operators against a following `=` (as `%` already is) so `*=` / `/=` are not mis-parsed as the operator followed by a failing operand. - AST: StmtTimesEq / StmtDivideEq, with name resolution, pretty printer and module type-ref renamer handling them. - Parser: `*=` / `/=` in both statement and for-clause assignment parsers; `=` guards on the `*` / `/` expression operators. - Tests: parser cases for `x *= 2;` / `x /= 2;`; a compound-operators.solc case test exercising the full `+= -= *= /= %= ^= &= |=` set; and new `basic` dispatch entry points (mul2 / div2 and pluseq / minuseq / timeseq / divideeq / modeq / bxoreq / bandeq / boreq) giving the compound assignment statements end-to-end EVM coverage. Co-Authored-By: Alex Beregszaszi <alex@rtfs.hu>
axic
force-pushed
the
compound-statements
branch
from
August 1, 2026 12:12
218bbc1 to
5445f89
Compare
23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
*//operators (ExpTimes / ExpDivide, backed by the Mul / Div classes) already exist, but the matching compound assignments were missing while+= -= ^= &= |= %=were all present. Add*=and/=so every binary arithmetic/bitwise operator has a compound assignment, desugaringlhs *= rhstolhs := lhs * rhs(and likewise for/=), mirroring the existing%=sugar.Guard the
*and/infix operators against a following=(as%already is) so*=//=are not mis-parsed as the operator followed by a failing operand.*=//=in both statement and for-clause assignment parsers;=guards on the*//expression operators.x *= 2;/x /= 2;; a compound-operators.solc case test exercising the full+= -= *= /= %= ^= &= |=set; and newbasicdispatch entry points (mul2 / div2 and pluseq / minuseq / timeseq / divideeq / modeq / bxoreq / bandeq / boreq) giving the compound assignment statements end-to-end EVM coverage.