You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
docs(deploy-tests): read client-cache's prefetch race as upstream - #446
This adds an upstream reading for one case of client-cache.original: "should refetch the full page after 5 mins". It failed once on cloudflare under Node.js 26 in the night's run of 2026-11-02 (run 41491299214), when #loading never showed after the second click.
The race. The test moves the clock on, goes back to /, and waits for the links' new prefetches with waitForIdleNetwork() before it clicks.
That wait is the document's own network idle, which the document reached when it first loaded, so it returns at once.
A click while the link's prefetch is still out finds the route pending. The router then navigates with one dynamic request and no loading state.
Reproduction. On next start 16.4.3 with no adapter, the test's own steps failed 3 of 20 runs.
What the judge reads. Only the second wait for #loading (line 386, after the clock moves on).
Releases. The suite is the same at 16.4.4, so the reading holds at both releases.
Changes
src/reviewed.ts: the reading.
REVIEWED.md: its record, under Upstream.
test/judge.test.ts: the recorded failure message.
Verification
The tools/deploy-tests tests (198), typecheck, lint, format and the vocabulary check pass.
Summary by cubic
Reads client-cache.original's "should refetch the full page after 5 mins" failure as an upstream race in deploy-tests, so the suite no longer flags it as a regression.
The test's waitForIdleNetwork() is answered by the document's own network idle, so a click while the link's prefetch is still out navigates with no loading state.
The judge reads only the second wait for #loading (line 386), after the clock moves on; the reading holds at 16.4.3 (29bbeab) and 16.4.4.
The race is the test's and the client router's, so the reading holds on both targets and under both Node.js versions; a failed prefetch of the link looks the same, so the reading applies only where the suite's respective prefetch cases passed in the same run.
Written for commit 6cce0ba. Summary will update on new commits.
Summary by CodeRabbit
Tests
Updated deployment test records to recognize a known timeout in an app-client-cache check on Cloudflare with Node.js 26. The record notes that the second loading-state wait fails; no user-facing functionality changes are included.
"should refetch the full page after 5 mins" of client-cache.original
failed once on cloudflare under Node.js 26 in the night's run of 2026-11-02
(run 41491299214): `#loading` never showed after the second click.
The test waits for the links' new prefetches with `waitForIdleNetwork()`,
which is the document's own network idle and returns at once. A click
while a prefetch is still out navigates with one dynamic request and no
loading state. vercel/next.js#87412 names the race, and the test's own
steps on `next start` 16.4.3 failed 3 of 20 runs with no adapter. The
judge reads only the second wait (line 386). The suite is the same at
16.4.4.
Use the checkbox below to choose whether this pull request gets preview deployments.
Build and deploy previews for this pull request
Checking this builds the latest commit and future pushes. Unchecking stops queued and future builds; a running build can finish and an existing preview stays available.
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.
The account paying for this security review has reached its Codex usage limits. The payer can check the Codex usage dashboard. For personal accounts, using credits requires enabling “Use credits for security reviews” in Code review settings. If you do not manage the paying account, contact this repository's admins.
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: da0a907f-49a6-4069-92f2-bddb35e65a6f
Commits
Reviewing files that changed from the base of the PR and between ca8f182 and 6cce0ba.
Files selected for processing: 2
tools/deploy-tests/REVIEWED.md
tools/deploy-tests/src/reviewed.ts
Walkthrough
Adds an upstream failure reading for an app-client-cache test in Next.js 16.4.3. The reading matches the reported #loading timeout at client-cache.original.test.ts:386. The change also records the timeout in the judge test data and documents the observed conditions.
Changes: App-client-cache failure record
Layer / File(s)
Summary
Match and document the upstream failure tools/deploy-tests/src/reviewed.ts, tools/deploy-tests/test/judge.test.ts, tools/deploy-tests/REVIEWED.md
Adds a matcher for the reported #loading timeout, includes the failure in the judge’s recorded failures, and documents the observed prefetch and network-idle conditions.
arkorlab/upwind#436: Derives the Next.js 16.4.4 reviewed groups from the 16.4.3 groups that this change updates.
Suggested reviewers:soleil-colza
Merge Risk: Moderate · previous review ca8f1
An adapter failure could be counted as an upstream test failure and let the deployment test pass. Resolve that classification risk before merging.
Pre-merge checks: 5
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title describes a docs-type change that records the client-cache prefetch race as an upstream issue, which matches the changeset (REVIEWED.md, reviewed.ts, and judge.test.ts all record that readin…
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title describes a docs-type change that records the client-cache prefetch race as an upstream issue, which matches the changeset (REVIEWED.md, reviewed.ts, and judge.test.ts all record that reading of the client-cache.original failure). It is specific and names the main point. The title does not mention the Node.js 26 or Cloudflare context, but it does not need to cover every detail.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 2 files. (1 skipped: 1 unsupported.)
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Run CodeRabbit Verify to test the changes in this pull request.
Recent review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: e533100b-01d7-41fe-ab94-17cd795db62e
Commits
Reviewing files that changed from the base of the PR and between 6ad11a5 and ca8f182.
Files selected for processing: 3
tools/deploy-tests/REVIEWED.md
tools/deploy-tests/src/reviewed.ts
tools/deploy-tests/test/judge.test.ts
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 3 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="tools/deploy-tests/src/reviewed.ts">
<violation number="1" location="tools/deploy-tests/src/reviewed.ts:330">
P2: This record applies to every target and Node.js lane, although the evidence only covers `cloudflare` under Node.js 26. Restrict the group to `targets: ['cloudflare']` and `nodes: ON_NODE_26` so matching failures in unverified lanes still fail the shard.</violation>
</file>
Reply with feedback, questions, or to request a fix.
The reason will be displayed to describe this comment to others. Learn more.
P2: This record applies to every target and Node.js lane, although the evidence only covers cloudflare under Node.js 26. Restrict the group to targets: ['cloudflare'] and nodes: ON_NODE_26 so matching failures in unverified lanes still fail the shard.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At tools/deploy-tests/src/reviewed.ts, line 330:
<comment>This record applies to every target and Node.js lane, although the evidence only covers `cloudflare` under Node.js 26. Restrict the group to `targets: ['cloudflare']` and `nodes: ON_NODE_26` so matching failures in unverified lanes still fail the shard.</comment>
<file context>
@@ -325,6 +325,21 @@ const AT_16_4_3: readonly Group[] = [
},
+ {
+ reading: 'upstream',
+ record: 'app-client-cache',
+ // The second wait for the loading state, after the clock moves on: the first follows a wait the
+ // document's own load answers, which leaves no prefetch out.
</file context>
…prefetches
- A prefetch of the adapter's that failed would skip the loading state as
well (CodeRabbit). The reading now holds only where the suite's cases
that prefetch again after five minutes, and prefetch a dynamic page in
part, passed in the same run (`beside`). In the runs that failed it,
both passed.
- The record names its release and commit, 16.4.3 at 29bbeab (cubic).
- The record says why it holds on both targets and under both Node.js
versions: the race is the test's and the client router's, and it fails
on `next start` with no adapter (cubic).
The account paying for this security review has reached its Codex usage limits. The payer can check the Codex usage dashboard. For personal accounts, using credits requires enabling “Use credits for security reviews” in Code review settings. If you do not manage the paying account, contact this repository's admins.
…ts prefetch cases
The comment and the record said "a prefetch of the adapter's" with no noun after it (cubic). They now say that a failed prefetch of the link skips the loading state too, so a failure is read only where the suite's cases that prefetch again after five minutes, and that prefetch a dynamic page in part, passed in the same run.
The account paying for this security review has reached its Codex usage limits. The payer can check the Codex usage dashboard. For personal accounts, using credits requires enabling “Use credits for security reviews” in Code review settings. If you do not manage the paying account, contact this repository's admins.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Summary
This adds an upstream reading for one case of
client-cache.original: "should refetch the full page after 5 mins". It failed once oncloudflareunder Node.js 26 in the night's run of 2026-11-02 (run 41491299214), when#loadingnever showed after the second click./, and waits for the links' new prefetches withwaitForIdleNetwork()before it clicks.next start16.4.3 with no adapter, the test's own steps failed 3 of 20 runs.#loading(line 386, after the clock moves on).Changes
src/reviewed.ts: the reading.REVIEWED.md: its record, under Upstream.test/judge.test.ts: the recorded failure message.Verification
The
tools/deploy-teststests (198), typecheck, lint, format and the vocabulary check pass.Summary by cubic
Reads
client-cache.original's "should refetch the full page after 5 mins" failure as an upstream race indeploy-tests, so the suite no longer flags it as a regression.waitForIdleNetwork()is answered by the document's own network idle, so a click while the link's prefetch is still out navigates with no loading state.next start16.4.3.#loading(line 386), after the clock moves on; the reading holds at 16.4.3 (29bbeab) and 16.4.4.Written for commit 6cce0ba. Summary will update on new commits.
Summary by CodeRabbit