repo-reprepro: log a count of skipped debs, not one line each - #10303
Merged
Conversation
The missing-deb skip added in the previous change echoed one line per absent deb. A single target can hold thousands of debs, and on a partial build most are absent, so this printed thousands of lines -- and when the caller runs the script under `set -x` (which reprints the long `for ... in <all debs>` header every iteration) the CI log ballooned to hundreds of MB. Count the skipped debs instead and log a single summary line per target. The selection and includedeb behaviour are unchanged. Signed-off-by: Igor Pecovnik <igor@armbian.com>
Contributor
📝 WalkthroughWalkthroughThe generated ChangesReprepro deb selection
Estimated code review effort: 2 (Simple) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #10301. That change skips debs missing on disk, but echoed one line per missing deb. A single target (e.g.
armbian) holds thousands of debs, and on a partial build most are absent — so the generatedreprepro.shprinted thousands of skip lines.Combined with the caller running it under
set -x(which reprints the very longfor one_deb in <all debs>header on every iteration), a CI run produced a ~200 MB log and a multi-minute step (observed in armbian/ci#35 test runs).Fix
Count the skipped debs and log a single summary line per target instead of one per deb:
Selection and
includedebbehaviour are unchanged. (Theset -xhalf is fixed on the caller side in armbian/ci#35.)Testing
bash -n.3 expected deb(s) not present on disk, skippedandincludedebreceives only the 2 present debs.Summary by CodeRabbit