Repository navigation
Conversation
The release job only needs write access to armoctl to push the manifest bump. Replace ARMOSEC_GITHUB_ACCESS_TOKEN (long-lived, org-wide) with a short-lived REPO_READ_WRITE App token limited to armoctl, contents:write. Docs-exempt: CI credential swap, no behavior change Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the org-wide
ARMOSEC_GITHUB_ACCESS_TOKENPAT in the release job with a short-lived token minted from theREPO_READ_WRITEGitHub App, scoped toarmoctlwithcontents: writeonly. armoctl is public; a long-lived PAT that reaches every armosec repo should not be readable by its workflows.Source of Truth
N/A — CI credential hardening (narrowing org secrets exposed to public repos), no ticket.
Changes
.github/workflows/pr-merged.yaml: addactions/create-github-app-tokenstep (repositories: armoctl,permission-contents: write) and use its token for checkout, so the manifest-bumpgit pushtomainuses the App identity.Prerequisites (org admin, before merge)
armosec/armoctlas a selected repo for org secretREPO_READ_WRITE_APP_PRIVATE_KEYand org variableREPO_READ_WRITE_APP_ID(armoctl sees neither today).REPO_READ_WRITEApp is installed onarmoctl.main). Today the PAT owner's bypass is what lets the bump commit land; without this the push is rejected.Testing
Not run: needs the prerequisites above. Verify with the next
release-labelled merge (orworkflow_dispatch): the bump commit should land onmainauthored via the App, and the release/S3 upload proceed as before.Docs
Docs-exempt: CI credential swap, no behavior change.
AI Context
open_pr🤖 Generated with Claude Code
AI-skills: none