Repository navigation
Conversation
utils-go has no armosec/kubescape module dependencies, so the ARMOSEC_GITHUB_ACCESS_TOKEN checkout token and git insteadOf rewrites are unused. Removing them stops a public repo from holding an org PAT. Docs-exempt: CI credential removal, no behavior change Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove
ARMOSEC_GITHUB_ACCESS_TOKENfrom both workflows. utils-go is public and has noarmosec/kubescapemodule dependencies, so the PAT checkout token and thegit insteadOfrewrites were unused, and a public repo should not hold an org-wide PAT.Source of Truth
N/A — CI credential hardening (narrowing org secrets exposed to public repos), no ticket.
Changes
.github/workflows/pr.yaml,.github/workflows/release.yaml: drop theGH_ACCESS_TOKENenv, the checkouttoken:, and the twoinsteadOfrewrites. Checkout falls back to the defaultGITHUB_TOKEN.Testing
go.modhas nogithub.com/armosec/*orgithub.com/kubescape/*requirements.GOPROXY=https://proxy.golang.org GIT_TERMINAL_PROMPT=0 go mod downloadandgo build ./...both succeed.PR Checksrun exercises the updated workflow.Docs
Docs-exempt: CI credential removal, no behavior change.
AI Context
open_pr🤖 Generated with Claude Code