Repository navigation
fix: prevent duplicate app.kubernetes.io/name in selector labels - #203
Closed
AdamMagued wants to merge 1 commit into
Closed
AdamMagued wants to merge 1 commit into
AdamMagued wants to merge 1 commit into
Conversation
Author
|
Closing in favor of earlier community PR #199 to keep the review queue clean. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When converting Kustomize manifests (such as default Kubebuilder scaffolding) containing app.kubernetes.io/name in selector/matchLabels fields, helmify outputs both the original hardcoded label and the {{- include ".selectorLabels" . | nindent X }} helper call. Because the selectorLabels template helper already defines app.kubernetes.io/name: {{ include ".name" . }}, the rendered Helm chart templates contain duplicate app.kubernetes.io/name mapping keys. Strict YAML parsers (such as ArgoCD or Kubernetes server-side apply) reject these manifests with mapping key duplicate errors.
Root Cause
Resource processors (deployment, daemonset, service, and poddisruptionbudget) construct selectors by serializing the original resource selector map and appending {{- include ".selectorLabels" . }}. Unlike resource metadata labels in pkg/processor/meta.go which strips labels managed by Helm (app.kubernetes.io/name, etc.), the selector and pod template label generation retained app.kubernetes.io/name from the incoming manifest. Furthermore, when app.kubernetes.io/name is the only selector label, serializing an empty map could produce invalid YAML ({}).
Solution
Fixes #196