Skip to content

fix(viewer): make sources compatible with the pending dependency majors [issue:#473] - #512

Merged
tcballard merged 2 commits into
mainfrom
claude/adr-083-rust-corpus-expansion-vizh3p
Oct 5, 2026
Merged

tcballard merged 2 commits into
mainfrom
claude/adr-083-rust-corpus-expansion-vizh3p

Conversation

@tcballard

Copy link
Copy Markdown
Collaborator

Summary

Unblocks the two red Dependabot PRs, #473 (rust-dependencies) and #436 (npm-dependencies). Each fix compiles on both the current and the bumped dependency versions, so it can land first and the Dependabot branches then rebase onto it.

Adds:

  • test(release): the test oracles hex-encode sha2 digests byte-wise (iter().map(|b| format!("{b:02x}"))) instead of using format!("{:x}", digest). sha2 0.11's hybrid-array digest no longer implements LowerHex, which is the chore(deps): bump the rust-dependencies group across 1 directory with 7 updates #473 compile error at decided/tests/federation_graph_support/mod.rs:212. Six call sites across four test files. sha2 is a dev-dependency only; the engine uses its own rac_engine::sha256.
  • fix(viewer): ListViewProps.searchRef is typed Ref<HTMLInputElement> instead of RefObject<HTMLInputElement>. Under React 19 types, useRef<HTMLInputElement>(null) returns RefObject<HTMLInputElement | null>, which is the chore(deps): bump the npm-dependencies group across 1 directory with 10 updates #436 tsc error at App.tsx:181. Ref<T> accepts the ref under both the React 18 and React 19 definitions; RefObject<T | null> does not compile on 18.

Scope

Included

  • Source compatibility fixes only. No dependency, lockfile or behaviour change.

Excluded

Verification

Ran

Covered

Review Path

  1. rac-localview/src/viewer/ListView.tsx
  2. The four Rust test files

Generated by Claude Code

]

sha2 0.11 returns a hybrid-array digest that no longer implements
LowerHex, so `format!("{:x}", digest)` stops compiling. The test oracles
now hex-encode the digest bytes directly, which compiles on 0.10 and 0.11
and lets the rust-dependencies update land.
…436]

React 19's useRef(null) returns RefObject<T | null>, which no longer fits
a RefObject<T> prop. Ref<HTMLInputElement> accepts the ref under both the
React 18 and React 19 type definitions, so the npm-dependencies update can
land without a lockstep change.
@tcballard
tcballard merged commit c5d818b into main Oct 5, 2026
15 checks passed
tcballard added a commit that referenced this pull request Oct 5, 2026
v0.31.2 builds the Linux release archives against a glibc 2.17 floor
(#511) and carries the rust-dependencies (#473), npm-dependencies (#436)
and github-actions (#448) updates, with the source compatibility fixes
they needed (#512).
tcballard added a commit that referenced this pull request Oct 5, 2026
v0.31.2 builds the Linux release archives against a glibc 2.17 floor
(#511) and carries the rust-dependencies (#473), npm-dependencies (#436)
and github-actions (#448) updates, with the source compatibility fixes
they needed (#512).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant