Repository navigation
fix(viewer): make sources compatible with the pending dependency majors [issue:#473] - #512
Merged
Merged
Conversation
…436] React 19's useRef(null) returns RefObject<T | null>, which no longer fits a RefObject<T> prop. Ref<HTMLInputElement> accepts the ref under both the React 18 and React 19 type definitions, so the npm-dependencies update can land without a lockstep change.
tcballard
added a commit
that referenced
this pull request
Oct 5, 2026
tcballard
added a commit
that referenced
this pull request
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unblocks the two red Dependabot PRs, #473 (rust-dependencies) and #436 (npm-dependencies). Each fix compiles on both the current and the bumped dependency versions, so it can land first and the Dependabot branches then rebase onto it.
Adds:
test(release): the test oracles hex-encodesha2digests byte-wise (iter().map(|b| format!("{b:02x}"))) instead of usingformat!("{:x}", digest).sha20.11's hybrid-array digest no longer implementsLowerHex, which is the chore(deps): bump the rust-dependencies group across 1 directory with 7 updates #473 compile error atdecided/tests/federation_graph_support/mod.rs:212. Six call sites across four test files.sha2is a dev-dependency only; the engine uses its ownrac_engine::sha256.fix(viewer):ListViewProps.searchRefis typedRef<HTMLInputElement>instead ofRefObject<HTMLInputElement>. Under React 19 types,useRef<HTMLInputElement>(null)returnsRefObject<HTMLInputElement | null>, which is the chore(deps): bump the npm-dependencies group across 1 directory with 10 updates #436tscerror atApp.tsx:181.Ref<T>accepts the ref under both the React 18 and React 19 definitions;RefObject<T | null>does not compile on 18.Scope
Included
Excluded
Verification
Ran
cargo test --release -p decided --test spec_bundle --test spec_federation --test point_in_time_federation -p decided-mcp --test spec_federationpasses.cargo test --workspace --releasegives 524 passed and 0 failed.cargo fmt --all --checkis clean andcargo clippy --workspace --all-targets --release -- -D warningsis clean.npm ci && npx tsc -b && npm test && npm run build && npm run build:viewersucceed, with 18/18 tests passing.Covered
LowerHexerror from its CI log, and the chore(deps): bump the npm-dependencies group across 1 directory with 10 updates #436TS2322error locally on its lockfile.Review Path
rac-localview/src/viewer/ListView.tsxGenerated by Claude Code