Skip to content

chore: add Español - es-ES language support #533

Open
SherlynS wants to merge 1 commit into
asgardeo:mainfrom
SherlynS:sherlynS-add-spa
Open

chore: add Español - es-ES language support #533
SherlynS wants to merge 1 commit into
asgardeo:mainfrom
SherlynS:sherlynS-add-spa

Conversation

@SherlynS

@SherlynS SherlynS commented Jun 29, 2026

Copy link
Copy Markdown

Purpose

Previously, the Asgardeo JavaScript SDK did not have support for Spanish (Español - es-ES). Users who prefered Spanish would not have been able see UI components translated, limiting accessibility for Spanish-speaking users.

This PR addresses this barrier and now customers who prefer Spanish will be able to see UI components translated and easily navigate through other UI components for each readability and use.

Related PRs/Issues

Changes

  • Added new es-ES.ts file for Spanish translation
  • Added to index.ts the export value to make Spanish translations importable across SDK
  • Added spanish-translation-bundle.md changeset to trigger a minor @asgardeo/i18n version bump
  • Modified CONTRIBUTING.md doc to showcase documentation caveats encountered in building and testing.

Testing

  • Followed option 2: testing with sample in order to verify changes

Checklist

  • Followed the CONTRIBUTING guidelines.
  • Manual test round performed and verified.
  • Documentation provided. - updated exiting documentation
  • no unit tests - only sample testing

Security checks

Summary by CodeRabbit

  • New Features

    • Added Spanish (es-ES) translation bundle support to the internationalization experience and SDK, improving the experience for Spanish-speaking users.
  • Documentation

    • Updated contribution guidance for testing translations, including the recommended build workflow, local verification steps, and environment setup for i18n changes.
    • Clarified which UI strings are expected to remain English (server-driven) versus which should be translated (bundle-driven).

@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b8299e32-5557-483a-8e3f-2f9c048badfe

📥 Commits

Reviewing files that changed from the base of the PR and between 2aac90d and a0e52f1.

📒 Files selected for processing (5)
  • .changeset/spanish-translation-bundle.md
  • CONTRIBUTING.md
  • packages/i18n/src/constants/TranslationBundleConstants.ts
  • packages/i18n/src/translations/es-ES.ts
  • packages/i18n/src/translations/index.ts
🚧 Files skipped from review as they are similar to previous changes (4)
  • packages/i18n/src/translations/es-ES.ts
  • packages/i18n/src/translations/index.ts
  • .changeset/spanish-translation-bundle.md
  • CONTRIBUTING.md

📝 Walkthrough

Walkthrough

Adds a Spanish (es-ES) translation bundle, exports and registers it as a default locale, updates translation testing instructions, and includes a minor changeset for @asgardeo/i18n.

Changes

Spanish translation bundle addition

Layer / File(s) Summary
es-ES translation bundle and export wiring
packages/i18n/src/translations/es-ES.ts, packages/i18n/src/translations/index.ts
Adds Spanish strings, locale metadata, the es_ES default export, and translations index registration.
Default locale registration
packages/i18n/src/constants/TranslationBundleConstants.ts
Adds es-ES to the documented and configured default locales while retaining en-US as the fallback locale.
Contributor testing docs and changeset
CONTRIBUTING.md, .changeset/spanish-translation-bundle.md
Updates Nx build, sample integration, environment setup, and translation verification guidance, and adds a minor release changeset.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: adding Spanish es-ES language support.
Description check ✅ Passed The description covers purpose, related links, testing, checklist, and security checks, with only minor template heading differences.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@SherlynS SherlynS force-pushed the sherlynS-add-spa branch from 24b120a to 2aac90d Compare July 3, 2026 01:56
@SherlynS SherlynS marked this pull request as ready for review July 8, 2026 01:41

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/i18n/src/translations/es-ES.ts`:
- Line 59: The Spanish translation in es-ES still uses the English label for the
elements.fields.email.label key, causing mixed-language UI text. Update the
translation entry in the es-ES locale file to a Spanish label such as “Correo
electrónico”, keeping the same key so the translations lookup continues to work
correctly.

In `@packages/i18n/src/translations/index.ts`:
- Around line 19-27: `es_ES` is exported from the translations index but not
loaded by the default bundle list, so add `es-ES` to
`TranslationBundleConstants.DEFAULT_LOCALES` and ensure
`getDefaultI18nBundles()` picks it up alongside the existing default locale(s).
Use the existing `es_ES` export in `translations/index.ts` and the
`DEFAULT_LOCALES` constant in `TranslationBundleConstants` to keep the runtime
defaults aligned.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 62aaca51-495f-4985-abf9-a98a75ee5607

📥 Commits

Reviewing files that changed from the base of the PR and between 24c36b4 and 2aac90d.

📒 Files selected for processing (4)
  • .changeset/spanish-translation-bundle.md
  • CONTRIBUTING.md
  • packages/i18n/src/translations/es-ES.ts
  • packages/i18n/src/translations/index.ts

Comment thread packages/i18n/src/translations/es-ES.ts Outdated
Comment thread packages/i18n/src/translations/index.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant