chore: add Español - es-ES language support #533
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (4)
📝 WalkthroughWalkthroughAdds a Spanish (es-ES) translation bundle, exports and registers it as a default locale, updates translation testing instructions, and includes a minor changeset for ChangesSpanish translation bundle addition
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
24b120a to
2aac90d
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/i18n/src/translations/es-ES.ts`:
- Line 59: The Spanish translation in es-ES still uses the English label for the
elements.fields.email.label key, causing mixed-language UI text. Update the
translation entry in the es-ES locale file to a Spanish label such as “Correo
electrónico”, keeping the same key so the translations lookup continues to work
correctly.
In `@packages/i18n/src/translations/index.ts`:
- Around line 19-27: `es_ES` is exported from the translations index but not
loaded by the default bundle list, so add `es-ES` to
`TranslationBundleConstants.DEFAULT_LOCALES` and ensure
`getDefaultI18nBundles()` picks it up alongside the existing default locale(s).
Use the existing `es_ES` export in `translations/index.ts` and the
`DEFAULT_LOCALES` constant in `TranslationBundleConstants` to keep the runtime
defaults aligned.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 62aaca51-495f-4985-abf9-a98a75ee5607
📒 Files selected for processing (4)
.changeset/spanish-translation-bundle.mdCONTRIBUTING.mdpackages/i18n/src/translations/es-ES.tspackages/i18n/src/translations/index.ts
2aac90d to
a0e52f1
Compare
Purpose
Previously, the Asgardeo JavaScript SDK did not have support for Spanish (Español - es-ES). Users who prefered Spanish would not have been able see UI components translated, limiting accessibility for Spanish-speaking users.
This PR addresses this barrier and now customers who prefer Spanish will be able to see UI components translated and easily navigate through other UI components for each readability and use.
Related PRs/Issues
Changes
es-ES.tsfile for Spanish translationindex.tsthe export value to make Spanish translations importable across SDKspanish-translation-bundle.mdchangeset to trigger a minor @asgardeo/i18n version bumpCONTRIBUTING.mddoc to showcase documentation caveats encountered in building and testing.Testing
Checklist
Security checks
Summary by CodeRabbit
New Features
Documentation