Repository navigation
Conversation
…l fails Only restore() checked that the package was installed after the install session. Snapshot and Mirror restores and the Neo-Backup and DataBackup imports ignored a failed install, then restored the data and reported success. - New install_ok: the same pm path --user check as restore(), with ERR_INSTALL on failure; used after each of the four install steps. - Create the install session only when there are APKs to write. - Neo import: a decrypt failure (APK or data archive) now ends with ERR_IMPORT_ENCRYPTED, so the WebUI asks for the password again, instead of skipping the item and reporting success. A session opened for the APKs is abandoned. Signed-off-by: ash-iir <254348575+ash-iir@users.noreply.github.com>
5 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backend #12. Only
restore()checkedpm pathafter the install session (the issue #7 fix). Snapshot restore, Mirror restore and the DataBackup and Neo-Backup imports ignored a failedinstall-commit, then wiped and restored the data and finished withok.install_ok <op>: the samefw pm path --user "$U" "$PKG"check asrestore(); on failure it audits and ends withERR_INSTALL(existing message). Called after the install step of all four, only when that step had APKs.apk/, a snapshot with no.apk, a DataBackupapk.tar.zstwith no APKs), so no session is left open.neo_item's loop with rc 0, so a wrong password skipped the data silently. It now ends withERR_IMPORT_ENCRYPTED, which the WebUI already answers by asking for the password again.pm install-abandonon the open session.Like
restore(), the check can't tell a failed update of an app that was already installed; the old version is still there, so the data restore goes on.Testing
sh -n,mksh -n,busybox sh -n;shellcheck -s sh: same warnings as main.do_restore_mirrorandinstall_okwith stubbedfw/rsync, under mksh R59, busybox 1.37 ash and dash: APKs + package missing afterwards givesERR_INSTALL; APKs + installed givesok; no APKs givesokand noinstall-createcall.