Skip to content

snow-chibi --install-prefix fix - #1225

Closed
Retropikzel wants to merge 1 commit into
ashinn:masterfrom
Retropikzel:chibi-scheme-install-prefix-fix-cleaned
Closed

Retropikzel wants to merge 1 commit into
ashinn:masterfrom
Retropikzel:chibi-scheme-install-prefix-fix-cleaned

Conversation

@Retropikzel

Copy link
Copy Markdown
Contributor
  • .github/actions/snow-chibi-tests/action.yaml
    • Add tests to make sure installing to prefix works and is not skipped because library is installed "globally"
  • Makefile
  • lib/chibi/snow/commands.scm
    • Remove unused function get-install-library-dirs
    • Move handling of prefix from get-install-dirs into get-install-library-dir, in the former it was only in some implementations
    • Insted of long cond which would need to have every implementation anyway pass the impl to the get-install-library-dir
    • If unknown implementation is given just throw an error in get-install-dirs, previously some path was returned and libraries where installed somewhere

I think this simplifies the code a bit too. Previously when I added support for new implementations I did not notice that some added the --install-prefix if it was there and left handling of it out for most implementations. Now it is always added and in one place only, so the implementation specific code can concentrate on just implementation specific stuff.

* Fix snow-chibi --install-prefix
@Retropikzel

Retropikzel commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor Author

I named the branch wrong and the tests do not run. I'll make a new pull request. Atleast the tests work as expected and did not run when the branch name did not start with "snow-chibi". 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant