Repository navigation
snow-chibi --install-prefix fix - #1225
Closed
Retropikzel wants to merge 1 commit into
Closed
Retropikzel wants to merge 1 commit into
Retropikzel wants to merge 1 commit into
Conversation
* Fix snow-chibi --install-prefix
Contributor
Author
|
I named the branch wrong and the tests do not run. I'll make a new pull request. Atleast the tests work as expected and did not run when the branch name did not start with "snow-chibi". 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this simplifies the code a bit too. Previously when I added support for new implementations I did not notice that some added the --install-prefix if it was there and left handling of it out for most implementations. Now it is always added and in one place only, so the implementation specific code can concentrate on just implementation specific stuff.