Repository navigation
Extend sexp_ratio overflow guards to the denominator. - #1227
Merged
ashinn merged 2 commits intoNov 19, 2026
Merged
Conversation
Contributor
Author
|
I don't fully understand the appveyor build errors or how they may relate to my change. The functional tests pass... |
Contributor
Some of the appveyor tests are broken everywhere, for example #1226. I usually just ignore them. |
Owner
|
Can you add a test case demonstrating the failure that would occur without this guard? |
Contributor
Author
Done. Should have started with that. |
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I may be missing a deeper motivation, and:
It seems like the overflow guards ought to apply to the denominator as well as the numerator.
Either way, thanks for looking.