Skip to content

Extend sexp_ratio overflow guards to the denominator. - #1227

Merged
ashinn merged 2 commits into
ashinn:masterfrom
elloskelling:dev/sexp_ratio_overflow_guards
Nov 19, 2026
Merged

ashinn merged 2 commits into
ashinn:masterfrom
elloskelling:dev/sexp_ratio_overflow_guards

Conversation

@elloskelling

Copy link
Copy Markdown
Contributor

I may be missing a deeper motivation, and:
It seems like the overflow guards ought to apply to the denominator as well as the numerator.
Either way, thanks for looking.

@elloskelling

Copy link
Copy Markdown
Contributor Author

I don't fully understand the appveyor build errors or how they may relate to my change. The functional tests pass...

@Retropikzel

Copy link
Copy Markdown
Contributor

I don't fully understand the appveyor build errors or how they may relate to my change. The functional tests pass...

Some of the appveyor tests are broken everywhere, for example #1226. I usually just ignore them.

@ashinn

ashinn commented Nov 17, 2026

Copy link
Copy Markdown
Owner

Can you add a test case demonstrating the failure that would occur without this guard?

@elloskelling

Copy link
Copy Markdown
Contributor Author

Can you add a test case demonstrating the failure that would occur without this guard?

Done. Should have started with that.
These should cover 32-bit and 64-bit overflow.

@ashinn

ashinn commented Nov 19, 2026

Copy link
Copy Markdown
Owner

Thanks!

@ashinn
ashinn merged commit 74c524d into ashinn:master Nov 19, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants