Skip to content

Fix snow-chibi --install-prefix - #1228

Merged
ashinn merged 2 commits into
ashinn:masterfrom
Retropikzel:snow-chibi-install-prefix-fix4
Nov 21, 2026
Merged

ashinn merged 2 commits into
ashinn:masterfrom
Retropikzel:snow-chibi-install-prefix-fix4

Conversation

@Retropikzel

@Retropikzel Retropikzel commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor
  • Add new test to check that when installing to prefix, library installation is not skipped
  • Remove handling of --install-prefix from get-install-dirs
    • I had misunderstood how the prefix should work and added these to some implementations
  • Remove unused get-install-library-dirs
  • Change Kawa builder/installer to use get-install-library-dir instead of get-install-dirs
  • Add handling of --install-prefix into get-install-search-dirs
    • This is the most important part

So the bug was that get-install-search-dirs did not consider --install-prefix and would go directly to the get-install-dirs which returns the implementation specific paths.

@Retropikzel

Copy link
Copy Markdown
Contributor Author

There is actually another problem too. Since the prefix check is not first in the conds it only now works with chibi. I'll fix that too.

@ashinn
ashinn merged commit a8baf09 into ashinn:master Nov 21, 2026
26 of 27 checks passed
@Retropikzel

Copy link
Copy Markdown
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants