Repository navigation
fix(docker): base plugin images on their exact build release - #246
Conversation
The plugin images were built for 8.0.45 / 8.4.8 / 9.7.0 but based on the floating mysql:8.0 / 8.4 / 9.7 (now 8.0.46 / 8.4.13 / 9.7.4); a library built for one MySQL release can crash another (an 8.4.8 component crashed 8.4.11 in #244's dry run). - docker-publish.yml (plugin job): build for 8.0.46, 8.4.13, 9.7.4, base each image on mysql:<that release>, also tag it with the release; run on a dry_run dispatch too, building and testing without pushing. - Dockerfile.oraclelinux8/9: MYSQL_VERSION is required (no default). - build-docker-local.sh: same releases; reject versions other than 8.0/8.4/9.7. - benchmark-issue79.yml: base the image on 8.4.8, the release it builds. - docs/DOCKER_IMAGES.md, CHANGELOG. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 12 seconds. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ea04398c41
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| case "$MYSQL_VERSION" in | ||
| 8.0) MYSQL_TAG="mysql-8.0.46" ;; | ||
| 8.4) MYSQL_TAG="mysql-8.4.13" ;; | ||
| 9.7) MYSQL_TAG="mysql-9.7.4" ;; |
There was a problem hiding this comment.
When a non-Apple user runs scripts/build-docker-local.sh 9.7 with the defaults, this selects MySQL 9.7.4 but the script configures GCC 10 below; MySQL 9.7 requires GCC 11 or later, so CMake rejects the build. The publish workflow already selects compiler 11 for this release. Please select a supported compiler for this local target too (MySQL 9.7 release notes).
Useful? React with 👍 / 👎.
|
@coderabbitai review |
Action not completed
|
…-images Keep both the plugin and the component pinning notes in docs/DOCKER_IMAGES.md and CHANGELOG. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Companion to #245, which does the same for the component images.
Why
A plugin or component library works only on the exact MySQL release it was built against. In #244's dry run, a component built for 8.4.8 crashed 8.4.11.
The plugin images were built for
mysql-8.0.45/mysql-8.4.8/mysql-9.7.0but based on the floatingmysql:8.0/mysql:8.4/mysql:9.7. Those tags now point to 8.0.46 / 8.4.13 / 9.7.4, so every published plugin image currently pairs the plugin with a newer server than it was built for.What
docker-publish.yml, plugin job (build-and-publish):mysql:<that release>.mysql8.0.46,mysql8.4.13,mysql9.7.4).mysql8.0/mysql8.4/mysql9.7/latestmove to these releases.dry_rundispatch: it builds, smoke-tests and runs the README examples without pushing. Before, the job could only be tested by releasing.Dockerfile.oraclelinux8/Dockerfile.oraclelinux9:MYSQL_VERSIONis required (no default).scripts/build-docker-local.sh: builds 8.0, 8.4 or 9.7 on the same releases and rejects other versions. It used to map9.0to 9.0.0, and silently built 8.4.8 for anything else.benchmark-issue79.yml: bases its image on 8.4.8, the release it clones.docs/DOCKER_IMAGES.md, CHANGELOG.Verification
A
dry_rundispatch on this branch builds all three plugin images (amd64 and arm64), smoke-tests their contents and runs the README examples, without pushing. The run is linked below.Note: this PR and #245 both add a paragraph at the same place in
docs/DOCKER_IMAGES.mdand an entry to CHANGELOG's Fixed section. Whichever merges second gets rebased.🤖 Generated with Claude Code