Repository navigation
Conversation
- mcp_http.bind_address (read-only, default 127.0.0.1): listen address. - mcp_http.ssl_cert / mcp_http.ssl_key (read-only): PEM files; with both, the endpoint serves HTTPS through Router's TlsServerContext (TLS 1.2+), as Router's http_server plugin builds it. - RFC 0001 §5.3: plain HTTP only on loopback (127.0.0.0/8, ::1, localhost). A non-loopback address without TLS, or only one of the two files, fails the install with an error in the log. test-mcp-endpoint.sh: both refusals, HTTPS on loopback and from another container over the bridge network (server-cert.pem from the datadir), and plain HTTP to the TLS port gets no reply. 37 checks. Part of #256 (RFC 0001 Phase 5). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 40 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 5 item from #256: TLS, mandatory off loopback (RFC 0001 §5.3).
Change
mcp_http.bind_address(read-only, default127.0.0.1): the listen address. The spike was hard-wired to127.0.0.1.mcp_http.ssl_cert,mcp_http.ssl_key(read-only): PEM files. With both set, the endpoint serves HTTPS through Router'sTlsServerContext(TLS 1.2+). The context is built the way Router'shttp_serverplugin builds it:load_key_and_certplus default DH.127.0.0.0/8,::1,localhost).Tests
scripts/test-mcp-endpoint.shonmysql:26.10.0: 37 passed, 0 failed. New checks:bind_address = '0.0.0.0'without TLS: the install is refused;0.0.0.0with the server's ownserver-cert.pem/server-key.pem: installs. Then:The existing loopback/plain-HTTP checks are unchanged.
Docs: settings table, network bullet, CHANGELOG.
Independent of #257–#262.
Part of #256.
🤖 Generated with Claude Code