Repository navigation
Conversation
Adds creator() (plus create / create_for_modification aliases) for
CosmosMongoDBAccount, CosmosMongoDBDatabase and CosmosMongoDBCollection as
hand-written overlays. Each emits the exact qualifiedName that
atlan-cosmosdb-app and atlan-cosmosnosql-app emit today:
{conn}/accounts/{account}/databases/{db}/collections/{collection}.
Database and Collection set the parent relationship and denormalised
attributes (account / database qualifiedNames, databaseName,
databaseQualifiedName), so validate(for_creation=True) passes.
connection_qualified_name is derived from the parent qualifiedName when
omitted.
The 3 classes are regenerated from atlanhq/models#2081, which adds the
matching qualifiedNameFormula.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011uG1w2Vm1KcdbnG1wpbCXc
# Conflicts: # pyatlan_v9/model/assets/cosmos_mongo_db_account.py # pyatlan_v9/model/assets/cosmos_mongo_db_collection.py # pyatlan_v9/model/assets/cosmos_mongo_db_database.py
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description
Adds
creator()for the 3 Cosmos MongoDB asset types in pyatlan_v9: CosmosMongoDBAccount, CosmosMongoDBDatabase, CosmosMongoDBCollection. Both atlan-cosmosdb-app and atlan-cosmosnosql-app emit these types with the same qualifiedName shape, so one creator per type fits both.{conn}/accounts/{account},.../databases/{db},.../collections/{collection}, the strings both apps emit today (FND-3838 census). A different string would re-key existing assets.cosmosMongoDBAccount+cosmosMongoDBAccountQualifiedName; Collection setscosmosMongoDBDatabase+cosmosMongoDBDatabaseQualifiedName+databaseName/databaseQualifiedName(inherited from Table, and set by both apps).validate(for_creation=True)passes with no extra checks in the overlay.connection_qualified_nameis optional on Database / Collection; when omitted it is the first 3 segments of the parent qualifiedName (a too-short parent QN raises).validate_required_fields).pyatlan_v9/model/assets/_overlays/cosmos_mongo_db_*.py; the 3 classes are regenerated from atlanhq/models with these overlays (pklsdkOnly=python+ pre-commit, the same steps assync-python-sdk.yaml).Linear: FND-3847 — required-attributes analysis table is in the issue comments.
Paired models PR (merge first): https://github.com/atlanhq/models/pull/2081 — adds the matching
qualifiedNameFormula, which drives the regenerated_QUALIFIED_NAME_PATTERN.🧩 Type of change
✅ How has this been tested?
tests_v9/unit/model/cosmos_mongo_db_test.py(26 tests): literal app qualifiedName per type, account → database → collection chaining, relationship + denormalised attributes, name pattern match,validate(for_creation=True), missing / blank / too-short inputs,createandcreate_for_modificationaliases.collections→containersfails the parity tests.pytest tests_v9/unit: 7701 passed, 5 skipped.pre-commitclean on all changed files.🤖 Generated with Claude Code
https://claude.ai/code/session_011uG1w2Vm1KcdbnG1wpbCXc