Repository navigation
Conversation
IcebergCatalog, IcebergNamespace, IcebergTable and IcebergColumn get a creator() whose qualifiedName matches atlan-iceberg-app exactly. Namespaces and nested columns are variable depth, so the creators take a parent qualifiedName rather than fixed segments. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015sDtmK7vhyKvgXHkSxH7ga
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description
Adds
creator()for the 4 Iceberg asset types in pyatlan_v9: IcebergCatalog, IcebergNamespace, IcebergTable, IcebergColumn. Follows the structure of the Cognos exemplar (#1078).app/qualified_names.py): namespacea.b→{catalog_qn}/a/b, nested column →{table_qn}/{path joined with /}. A different string would re-key existing Iceberg assets.database*), namespace (schema*), table,icebergNamespaceHierarchy, plus for nested columnsparentColumnName/parentColumnQualifiedName,columnDepthLevelandcolumnHierarchy. Relationships match the app too:database→ IcebergCatalog,atlanSchema→ IcebergNamespace,table→ IcebergTable (also on nested columns).icebergParentNamespaceQualifiedNameis the immediate parent, as the typedef describes. The app uses the first dotted segment (census app bug), so the two differ only for namespaces 3+ levels deep. The qualifiedName is the same.validate_required_fields, segment-count checks, parent column must sit under the given table,order >= 0).qualifiedNameFormulacannot express variable depth. The default (parentQN + "/" + name) already describes all four types.pyatlan_v9/model/assets/_overlays/iceberg_*.py. The 4 classes are regenerated from atlanhq/models master30fb7dfwith these overlays (sdkOnly=python, the same steps assync-python-sdk.yaml). Only the creators and their imports change, and pre-commit makes no changes to the generated output.Linear: FND-3868. The analysis table (required attrs, denormalised attrs, relationships, blank behaviour) is recorded there.
🧩 Type of change
✅ How has this been tested?
tests_v9/unit/model/iceberg_test.py(48 tests): the literal app qualifiedName for every census template at 1, 2 and 3 namespace levels, including the first-segment namespace variant, the{ancestor_path|join('/')}and rebased{conn}{qn}column variants, and 3-level nested columns. Also covers the denormalised attributes, relationship serialisation,validate(for_creation=True), missing / blank / malformed inputs, and thecreatealiases.qualified_names.py(2d6c542), including connection ids,-/_names and 4-level namespaces.pytest tests_v9/unit: 7967 passed, 5 skipped.pre-commitclean on all changed files.📋 Checklist
🤖 Generated with Claude Code
https://claude.ai/code/session_015sDtmK7vhyKvgXHkSxH7ga