Repository navigation
Conversation
Adds hand-written creator overlays for SalesforceOrganization,
SalesforceObject, SalesforceField, SalesforceReport and SalesforceDashboard,
and regenerates the 5 classes from atlanhq/models master with them.
Each creator emits the exact qualifiedName atlan-salesforce-app emits today
(FND-3838 census):
Organization {conn}/{source_id}
Object {org}/{api_name}
Field {object}/{api_name}
Report {org}/{source_id}
Dashboard {org}/{source_id}
Object, Field, Report and Dashboard take the parent qualifiedName, set the
denormalised parent qns and the requiredForCreation parent relationship, and
derive connection_qualified_name from the parent when it is not given. Blank
inputs and too-short parent qns raise.
No models change: the containment-derived _QUALIFIED_NAME_PATTERN already
matches these shapes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019fLee6iVYNyoTkguJombqF
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description
Adds
creator()for the 5 Salesforce asset types in pyatlan_v9: SalesforceOrganization, SalesforceObject, SalesforceField, SalesforceReport, SalesforceDashboard. The structure follows the Cognos exemplar (#1078).{conn}/{source_id}{org}/{api_name}organization{object}/{api_name}object{org}/{source_id}organization{org}/{source_id}organization{org}/{api_name}shape.organization_qualified_name/object_qualified_namerequiredForCreationin the typedefconnection_qualified_name, derived from the parent qn when it isn't passedname(the Salesforce label) andapi_nameare separate inputs, as in the app.validate_required_fields). A parent qn with too few segments also raises._QUALIFIED_NAME_PATTERNalready matches these shapes. A{organizationQualifiedName}/…formula would make the pattern looser. SalesforceOrganization has no pattern because it has no containment parent.{org}/{id}, but a collision can't happen in practice. Salesforce ids carry a per-object key prefix (00Ofor reports,01Zfor dashboards).Linear: FND-3858. The analysis table is in the issue comments.
🧩 Type of change
✅ How has this been tested?
tests_v9/unit/model/salesforce_test.py(48 tests) covers:validate(for_creation=True)connection_qualified_namecreatealiasmap_*functions (origin/main) and compared each against the creator output. Compared fields: qn, connection qn, connector,api_name/source_id, the denormalised qns and the parent ref qn. Result: 0 mismatches.pytest tests_v9/unit: 7967 passed, 5 skipped.tests_v9/integration/salesforce_asset_test.pyis added. It creates a connection and all 5 types through the creators, retrieves each, asserts the exact qn and the parent links, then purges everything. It has not been run locally against a tenant yet.📋 Checklist
🤖 Generated with Claude Code
https://claude.ai/code/session_019fLee6iVYNyoTkguJombqF