Repository navigation
Conversation
Adds a hand-written creator overlay for QuickSightAnalysisField and injects
it into the generated class. The creator emits
{analysis_visual_qualified_name}/{quick_sight_id}, the exact string
atlan-quicksight-app emits today (FND-3838 census). It derives the analysis
and connection qualifiedNames from the visual qualifiedName when not given,
sets the quickSightAnalysisVisual parent relationship, and raises on blank
inputs or a malformed visual qualifiedName.
tests_v9/unit/model/quick_sight_analysis_field_test.py asserts the literal
app qualifiedName.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017NfZDWbifv53T5tLdbK4KN
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
QuickSightAnalysisField.creator()/updater()/trim_to_required()as an overlay (pyatlan_v9/model/assets/_overlays/quick_sight_analysis_field.py) and injects it into the generated class.{analysis_visual_qualified_name}/{quick_sight_id}, the exact stringatlan-quicksight-appemits today (FND-3838 census), so the app can swap its hand-built wire dict for this creator.validate(for_creation=True)passes fromname,quick_sight_idand the visual qn. Sets thequickSightAnalysisVisualparent relationship.ValueError.Analysis table: posted on FND-3884.
Test plan
tests_v9/unit/model/quick_sight_analysis_field_test.py: parity test asserts the app's literaldefault/quicksight/123/an1/sh1/vis1/dset1-total, plus blank/invalid inputs, derivation, updaterasset_methodsunit tests pass (583)馃 Generated with Claude Code
https://claude.ai/code/session_017NfZDWbifv53T5tLdbK4KN