Conversation
samliok
added this pull request to stack #522
September 14, 2026 21:37
yacovm
reviewed
Sep 15, 2026
| return c, nil | ||
| } | ||
|
|
||
| func (c *nonValidatorCommunication) Validators() common.Nodes { |
Collaborator
There was a problem hiding this comment.
I'm not a big fan of this approach. We should ideally not go to the P-chain every time we need to query the validator set of our L1.
Ideally we'll cache the result and only update it when we know for sure that we have changed the validator set.
Since the platform chain is the first chain to bootstrap, we should have an up to date chain by the time it finished bootstrapping.
Every subsequent query should return a cached value which will be updated when there is evidence for it (we saw a finalization of a sealing block)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The non-validator communication should be different than the validator one, mainly because non-validators run over multiple epochs and validator sets can change in the meantime. This makes the
validatorsfunction call return query the pchain.Also rather than changing the communication api, I made it so errors fetching the pchain are logged as warns.
This also closes #543 and some comments on the previous PR in the stack as well