Repository navigation
TOOLS-136: Support remote HTTPS OAuth callbacks - #166
Merged
averycrespi merged 1 commit intoOct 13, 2026
Merged
Conversation
averycrespi
marked this pull request as ready for review
October 12, 2026 23:23
9 tasks done
averycrespi
added this pull request to stack #170
October 13, 2026 19:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Implements TOOLS-136: complete upstream OAuth from a remote browser behind an HTTPS reverse proxy without an SSH tunnel.
Stacked on #165, targeting
avery/tools-135-remote-servingrather thanmain. Incremental base:a2c70776b2c85838ffea3bb28460a6b77be48f6f.Changes
/oauth/callback, reusing the main listener and preserving exact redirect bytes throughout registration, authorization and exchange.Review Notes
Review the incremental diff from #165; tests exercise the cumulative tree. Private HTTPS MCP upstream policy is intentionally unchanged (TOOLS-137). The fixture proves usable installed encrypted OAuth credentials with the existing test-only resolver/dial seam after stopped generation read; it does not claim running-Gateway private-upstream support.
No real provider credentials, live installation, Docker build/runtime, deployment or registry publication are involved. Provider-specific registration acceptance remains separate qualification.
Test Plan
Passed locally:
make -C agent-gateway verify,test-securityandtest-harness(including documentation/link checks)npm run format:checkExact-head target-applicable CI is required before draft promotion.