Repository navigation
docs: correct stale agent lists, five broken anchors, and two wrong repo URLs - #35
Merged
Merged
Conversation
…epo URLs Loose ends from PRs #31 and #32, plus link rot two earlier link-fix PRs could not catch because they resolved file paths only, never anchors. Stale agent lists (both are user-facing help, not comments): - run-benchmark-batch.sh:45 listed "pi (default), claude, omp, kiro". The flag is parsed generically and forwarded, and `-h` prints the script's own header block, so that line IS the help. Added codex, strands and strands-harness. - .claude/skills/benchmark/SKILL.md: the example command line offered --agent claude|pi|omp|codex|kiro, missing both agents PR #32 wired up. Broken anchors, all five verified absent on both sides before retargeting: - path-open-weight-on-bedrock-litellm.md pointed at path-anthropic-on-bedrock.md#anthropic-only. Self-inflicted: d92bf64 renamed that heading to "Supported models" without touching the inbound link. - docs/vision.md used ../README.md#results-a-worked-example TWICE (lines 3 and 26) and #quality-by-dimension-where-models-are-strong-or-weak once. No such headings exist here or upstream. Repointed at the Step 1 heading and at cost-per-task-methodology.md. - benchmarks/README.md:103 pointed at ../README.md#does-routing-beat-picking-one-model, also nonexistent. Repointed at docs/swe-router-evaluation.md. Wrong repo identities: - self-hosted/vllm/README.md:109 cloned sample-claude-code-multi-model, the predecessor repo, then cd'd into a script that lives in THIS one. The ~/repo target is kept so the following cd still works. - .claude/skills/benchmark/SKILL.md:69 was `cd ~/agentic-coding-harness- benchmarks`, the fork's clone directory name. Checked with an anchor-aware sweep of all 77 markdown files. Worth recording how GitHub builds a slug, because getting it wrong manufactures false positives: it lowercases, drops anything that is not a word character, space or hyphen (underscores are word characters and survive), then replaces EACH space with a hyphen without collapsing runs. So removed punctuation leaves a DOUBLE hyphen -- "API / CLI Design" is #api--cli-design, not #api-cli-design. Links like #pagedattention--kv-cache and #client-test-programs-pyprojecttoml--uv are correct as written and are deliberately untouched. After this the sweep reports one remaining item, SUPPORT.md -> ../../issues, which is the GitHub relative-URL idiom for the repo's issues page and resolves on github.com. Left alone, as PR #29 left it. 530 tests pass with no new failures; shell syntax checked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Loose ends from PRs #31 and #32, plus link rot that PRs #28 and #29 could not catch because they resolved file paths only, never anchors.
Stale agent lists
Both are user-facing help text, not comments:
run-benchmark-batch.sh:45listedpi (default), claude, omp, kiro. The flag is parsed generically and forwarded to the orchestrator, and-hprints the script's own header block — so that line is the help. Addedcodex,strands,strands-harness..claude/skills/benchmark/SKILL.mdoffered--agent claude|pi|omp|codex|kiro, missing both agents PR fix(harness): wire the Strands runner into the harness so --agent strands runs #32 wired up.Five broken anchors
Each verified absent on both sides before retargeting:
path-open-weight-on-bedrock-litellm.md→path-anthropic-on-bedrock.md#anthropic-onlyd92bf64renamed that heading to "Supported models" without touching the inbound linkdocs/vision.md→../README.md#results-a-worked-exampledocs/vision.md→../README.md#quality-by-dimension-where-models-are-strong-or-weakbenchmarks/README.md:103→../README.md#does-routing-beat-picking-one-modeldocs/swe-router-evaluation.mdTwo wrong repo identities
self-hosted/vllm/README.md:109clonedsample-claude-code-multi-model— the predecessor repo — and the very next linecds into a script that lives in this one. Kept the~/repotarget so the followingcdstill works..claude/skills/benchmark/SKILL.md:69wascd ~/agentic-coding-harness-benchmarks, the fork's clone directory name. Cloning this repo givessample-agentic-coding-harness-benchmarks.How GitHub builds a slug — worth recording
My first pass at an anchor checker reported 10 broken links. Seven were the checker's fault, not the repo's. GitHub lowercases, drops anything that is not a word character / space / hyphen (underscores are word characters and survive), then replaces each space with a hyphen without collapsing runs. So removed punctuation leaves a double hyphen:
API / CLI Design→#api--cli-design, not#api-cli-designLinks like
#pagedattention--kv-cacheand#client-test-programs-pyprojecttoml--uvare therefore correct as written and are deliberately untouched. Anyone adding an automated link check should encode that rule or it will generate noise.With the rule right, a sweep of all 77 markdown files found exactly the five anchors above. After this PR it reports one item:
SUPPORT.md → ../../issues, which is the GitHub relative-URL idiom for the repo's issues page and resolves on github.com. Left alone, as PR #29 left it.Deliberately not in scope
README.mdanddocs/repository-structure.mdboth want one-line additions (anonboard-benchmarkrow in the documentation map, and a tree entry) — but PR #33 is already editing both files, so those go in a follow-up once it merges rather than creating a conflict now.Checks
530 tests pass with no new failures;
bash -nclean on the modified script.