Repository navigation
docs(readme): fix the swe-router video embed and regenerate the Step 1 chart - #40
Merged
Merged
Conversation
…1 chart
The video asset was fine; the markup around it was not. GitHub rewrites any
video embed -- bare URL, <video> tag, even a plain link -- into its own
<details> player, so the wrapper the README added could only get in the way,
and did three things:
- <p align="center"> never applied. A block element cannot nest in a
paragraph, so GitHub closed the <p> before the player and left a stray
empty <p></p> behind it.
- the fallback text and the "Download the swe-router explainer" link were
discarded outright -- the rendered <video> body came back empty. Dead
markup that read like a working fallback.
- width="820" was dropped for GitHub's own max-height.
Replace all five lines with the bare asset URL on its own line, the form
GitHub documents. Verified against the /markdown API rather than by eye.
Regenerate docs/images/cost-quality-abstracted.png from the diagram source at
1600x1104 with a 2x device scale factor, which reproduces the committed
3200x2208 geometry, and bring the chart in line with the masked data:
- renumber the closed-source labels to the full measured set, so one model
carries one name across the chart, models.json, allowed-models.txt and
both swe-router evaluation docs. The chart was the last artifact calling
closed-frontier-gen5 "gen 3".
- correct the counts to twenty-three measured and eleven omitted; the
subtitle had lagged the data twice already.
- point the footnote at vend/swe-router/models.json instead of saying the
numbering is local to the chart, which is no longer true.
Also correct the caption under the chart: it told readers to regenerate this
diagram with the scripts in benchmarks/scripts/, but it is hand-maintained
HTML. It now carries the render recipe and sends the plot scripts to their
real use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two fixes to the front page, plus the chart rebuild they forced.
The video
The asset was never broken — it still 302s to a valid mp4. The markup around it was. GitHub rewrites any video embed into its own
<details>player, so the wrapper the README added could only get in the way. Checked against the/markdownAPI rather than by eye:<details>player<video src=...><details>player<details>playerSo the chrome is GitHub's either way, and the wrapper was doing three things, all bad:
<p align="center">never applied. A block element cannot nest in a paragraph, so GitHub closed the<p>before the player and left a stray empty<p></p>behind it. The video was never centred.<video>body came back empty — the "Your browser cannot play this video inline" text and the download link were dropped outright. Dead markup that read like a working fallback to anyone maintaining the file.width="820"was dropped for GitHub's ownmax-height:640px.Five lines become one: the bare asset URL on its own line, the form GitHub documents. Same player, no broken wrapper, no dead fallback. The centred italic caption below it is untouched and still centres.
markdownlintwill flagMD034/no-bare-urlson that line — that is the intended form, and the file already carriesMD033warnings by design.The Step 1 chart
Regenerated
docs/images/cost-quality-abstracted.pngfromdocs/diagrams/cost-quality-abstracted.htmlat 1600×1104 with a 2× device scale factor, which reproduces the committed 3200×2208 geometry exactly. The diagram also gained a data point that had not been rendered yet, and the rebuild was the moment to settle the naming:gen 3→gen 5,gen 4→gen 6,gen 2→gen 4, mid-tiergen 3→gen 5. The chart was the last artifact still callingclosed-frontier-gen5"gen 3", so one model now carries one name across the chart,vend/swe-router/models.json,allowed-models.txtand bothswe-routerevaluation docs.models.json).vend/swe-router/models.jsoninstead of stating the numbering is local to the chart, which stopped being true.One more README correction
The caption under the chart told readers to regenerate this diagram "with the chart scripts in
benchmarks/scripts/". It is hand-maintained HTML, and those scripts plot from run metrics. The caption now carries the actual render recipe and sends the plot scripts to their real use.Type of Change
Checklist
bash -nsyntax checkpython3 -m py_compileVerification
README.mdresolves.SKILL_FILESinvend/swe-router/install.sh.models.json:$11.95/82.83,$4.44/81.16,$4.67/76.97,$5.32/74.69,$4.18/66.32.cd benchmarks && uv run python -m unittest discover -s tests→ 614 tests, one failure (test_judge_common.test_lowercase_preferred_on_collision), which also fails on a stashed tree: a case-insensitive-filesystem issue unrelated to this change. pre-commit passes.One claim left alone: the
Models-45 from 11 providersbadge.litellm-mantle.yamlcarries roughly 39, but the badge may be counting the repo's whole reach, so it needs an owner's call rather than a guess.