fix(dev): support Node tool shims on Windows - #2054
Merged
Merged
Conversation
aidandaly24
had a problem deploying
to
e2e-testing
August 20, 2026 01:50 — with
GitHub Actions
Failure
Contributor
Package TarballHow to installgh release download pr-2054-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.27.1.tgz |
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
aidandaly24
temporarily deployed
to
e2e-testing
August 20, 2026 13:01 — with
GitHub Actions
Inactive
Hweinstock
reviewed
Aug 20, 2026
Hweinstock
left a comment
Contributor
There was a problem hiding this comment.
is there any way we can get a windows env to test this? want to make sure we're good to unblock #2050 (comment).
Contributor
|
I verified this works with a Windows Environment. However, we should look into using cross-spawn. It handles platform specific behaviors for us like converting file path into Windows compatible path. We should use this in the refactor dev one when we can. |
jariy17
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the two consecutive Windows failures that prevent TypeScript CodeZip agents from starting
under
agentcore dev.On Windows, npm package commands are commonly
.cmdshims and cannot be launched directly throughNode's
spawnAPIs. The dev server previously raw-spawned bothnpm installandnpx tsx watch .... The install failure also discarded the process creation error and displayedunknown error; manually installing dependencies only advanced the flow to the samespawn npx ENOENTfailure.This change:
npx tsx watchthrough the platform shell on Windows while preserving direct spawningon POSIX
unknown errorand web-UI log persistence
Related Issue
Closes #1849
Closes #2036
Documentation PR
N/A. This restores the documented TypeScript development workflow on Windows.
Type of Change
Testing
How have you tested the change?
npm run test:unitandnpm run test:integnpm run typechecknpm run lintsrc/assets/files were modifiedAdditional verification:
npm run buildnpm run format:checklocal end-to-end execution
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.