Repository navigation
Fix Azure VM Windows test flags splitting on dotted build IDs - #774
Merged
Merged
Conversation
AzureVM-default-otel-Windows failed on every attempt of the v1.300074.0 release run (https://github.com/aws/amazon-cloudwatch-agent/actions/runs/36720704729) and on every main run with a version-style BUILD_ID. TestMain exits in ~0.2s with "instanceId flag is required", and no test ever runs. Root cause: the remote-exec runs the test script through Windows PowerShell 5.1 (powershell.exe -EncodedCommand). PowerShell splits an unquoted '-'-prefixed argument at its first '.' (PowerShell/PowerShell#6291) Fix: single-quote every -flag=value argument (and the test dir) on the go test line so each one reaches go intact. The EC2 Windows suite doesn't hit this because it runs validator.exe from cmd.exe, not PowerShell. No other go test caller in terraform/ runs under PowerShell.
EduVencovsky
approved these changes
Oct 1, 2026
bhavya76
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue
AzureVM-default-otel-Windows failed on every attempt of the v1.300074.0 release run (https://github.com/aws/amazon-cloudwatch-agent/actions/runs/36720704729) and on every main run with a version-style BUILD_ID. TestMain exits in ~0.2s with "instanceId flag is required", and no test ever runs.
Root cause: the remote-exec runs the test script through Windows PowerShell 5.1 (powershell.exe -EncodedCommand). PowerShell splits an unquoted '-'-prefixed argument at its first '.'
(PowerShell/PowerShell#6291)
Description of changes
Single-quote every -flag=value argument (and the test dir) on the go test line so each one reaches go intact. The EC2 Windows suite doesn't hit this because it runs validator.exe from cmd.exe, not PowerShell. No other go test caller in terraform/ runs under PowerShell.
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Successful test run with from fix branch: https://github.com/aws/amazon-cloudwatch-agent/actions/runs/36855775812