Skip to content

value-less query parameter parsing in URI canonicalization#3850

Open
pulimsr wants to merge 3 commits into
mainfrom
url-query-string-cononicalization
Open

value-less query parameter parsing in URI canonicalization#3850
pulimsr wants to merge 3 commits into
mainfrom
url-query-string-cononicalization

Conversation

@pulimsr

@pulimsr pulimsr commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pulimsr pulimsr marked this pull request as ready for review June 17, 2026 21:23
@sbiscigl

Copy link
Copy Markdown
Collaborator

some general feedback:

  • lets actually remove this customization and test it to make sure that we do it right, can be a manual test or integration test.
  • lets add a URI test that fails before and passes after

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants