fix(runtime): update shell session wire protocol - #642
Conversation
|
|
Claude Security Review: no high-confidence findings. (run) |
| reconnect_window: Optional[float] = _DEFAULT_RECONNECT_WINDOW | ||
| outer_loop_delay: float = _DEFAULT_OUTER_LOOP_DELAY | ||
| on_reconnect: Optional[Callable[[bool], Union[Awaitable[None], None]]] = field(default=None, repr=False) | ||
| on_reconnect: Optional[Callable[[], Union[Awaitable[None], None]]] = field(default=None, repr=False) |
There was a problem hiding this comment.
Could we update the open_shell() docstring in src/bedrock_agentcore/runtime/agent_core_runtime_client.py? It still shows on_reconnect(reconnected: bool) and says that exiting the context sends a CLOSE frame. The callback now takes no arguments, and exiting the context now detaches the shell.
I can also make this change after this is merged, but will reapprove if you update. Thanks.
Issue #, if available:
Description of changes:
Updates the shell session wire protocol to simplify the connection handshake and remove deprecated features:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.