Repository navigation
fix(docs): allow customizable preview stage height and expand navbar stage - #82
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 38 minutes. View limit details
No actionable comments were generated in the recent review. ℹ️ Recent review info
Walkthrough
Merge Risk:
|
sapatmohit
left a comment
There was a problem hiding this comment.
Verified locally: with menus open, the desktop language dropdown, the 390px mobile menu and the 390px language dropdown all fit inside the card (110px+ to spare), with no horizontal overflow at 390px.
Only remaining item from #46's acceptance list: please add screenshots to the PR description, desktop and ~390px, light and dark, with the language menu / mobile menu open.
sapatmohit
left a comment
There was a problem hiding this comment.
Thanks @TanmayNileshShinde, merging now.
Resolves #46
Summary of Changes
stageClassName?: stringprop toPreviewCardandPreviewComponentsso documentation previews can pass custom stage height and container styling.fullBleedpreview stage min-height tomin-h-[22rem](352px).stageClassName=min-h-[26rem]on<PreviewComponents registryName=navbar ...>incontent/docs/components/navigation/navbar.mdxso the floating navbar's open language dropdown and mobile menu fit inside without being clipped by the card boundary.Summary by CodeRabbit
New Features
Improvements