Repository navigation
Check pushes to main for hand edits to releases.md, against the tip before the push, so one that passed its pull request's check still fails. - #90
Merged
Conversation
…p before the push.
…ndencies are, so newer Cargo does not report them as unused.
…e:` trailer only on a commit that writes exactly the generated notes.
ioquatix
commented
Nov 14, 2026
ioquatix
left a comment
Contributor
Author
There was a problem hiding this comment.
Independent review: no must-fix findings. I pushed one commit that requires bake-releases 0.3.12 and locks it, so this repository's own releases job uses the stricter trailer rule.
BAKE_BASEresolves correctly for every event. Pull requests getHEAD^1, merge groups getmerge_group.base_sha(beforeis not set there), and pushes getbefore. A multi-commit push judges every non-merge commit in the range. Manual runs and an all-zerobeforecheck nothing. That is right for manual runs: checking against the last tag would re-judge history that already landed, including releases made before the notes were generated.fetch-depth: 0brings the tags that the regeneration needs.- With 0.3.12, a forged
Release: v0.1.13hand edit on top of this branch is rejected, while the real v0.1.12 release commitabd59d7still passes. - The
use base_design as _;anduse base_security as _;lines are correct and the smallest possible fix. Both crates are context-only dependencies, linked the same way as the others. Tests pass withCARGO_BUILD_WARNINGS=deny. - The template matches
context/setup.md, which says to copy thisreleasesjob into thetest-resultaggregate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
releasesjob ranreleases:checkonly on pull requests and merge groups, so a hand edit toreleases.mdthat got past the pull request's check, for example with a forgedRelease:trailer on its own commits as the review of #88 reproduced, landed onmainunchecked. On pushes the job now checks againstgithub.event.before, the tip ofmainbefore the push, so the squash commit is judged by the commits it landed; pull requests still useHEAD^1, the current base in GitHub's merge commit, merge groups their own base, and manual runs check nothing. A scripted repository with such a hand edit shows the effect: with bake-releases 0.3.11, the pull request's check passes and the push check now fails; a squash whose description carries the trailer still passes both until base-rs/bake-releases#39, which counts a trailer only on a commit that writes exactly the generated notes, is released and the lockfile updated, after which all three fail. Repositories that copy this job, as thebase-project-setupandbase-project-updateskills say, get the change from here. CI also needed one unrelated fix: the runner's newer Cargo reportsbase-designandbase-securityas unused dependencies, whichCARGO_BUILD_WARNINGS: denyturns into an error, sosrc/lib.rsnow links them withuse … as _;as it already does the other crates that supply agent context.