Repository navigation
DOC: Add release notes for the rsquared_adj and Wald name fixes - #1019
Merged
Merged
Conversation
bashtage
marked this pull request as ready for review
November 11, 2026 16:33
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1019 +/- ##
==========================================
- Coverage 99.44% 99.06% -0.39%
==========================================
Files 153 151 -2
Lines 34278 33513 -765
Branches 2595 2595
==========================================
- Hits 34088 33199 -889
- Misses 114 214 +100
- Partials 76 100 +24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the 9.0 release notes for two contributor fixes that were merged without one, and adds their author to the contributors.
rsquared_adjwithout a constant (Changes that alter results):ZeroMean, andARX,HARXandLSwithconstant=False, adjusted their uncenteredrsquaredwith(nobs - 1) / (nobs - k), the factor of a centered R-squared. They now usenobs / (nobs - k), as statsmodels does.ZeroMeanreported anrsquared_adjof1 / nobs, although itsrsquaredis 0.WaldTestStatistic(Bug fixes): the name was also printed between H0 and H1. This affected the output ofarch_lm_testand of the VaR backtests, and it has been there since 4.8.0.Both bugs are in 8.0.0.
Checks
rsquared_adjon main: an AR(1) without a constant gives 0.021349, the same as statsmodels OLS, where the 8.0 formula gives 0.031235, itsrsquared. With a constant, it equals statsmodels as before.9.0.rstwith no warnings.🤖 Generated with Claude Code