Repository navigation
Remove note formatting docs for the 1.0 removal - #54
Open
phernandez wants to merge 1 commit into
Open
phernandez wants to merge 1 commit into
phernandez wants to merge 1 commit into
Conversation
Core PR basicmachines-co/basic-memory#2057 removes format_on_save, formatter_command, formatters, formatter_timeout, the built-in mdformat formatter, and the bm format command. Drop the Formatter settings section from the configuration reference and the bm format entries from the CLI reference and CLI basics. Note the removal in the 1.0 changelog breaking changes and add a short section to Migrating to 1.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CMYVKyv6fNv5MUtAeTDALb Signed-off-by: phernandez <paul@basicmachines.co>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Docs for core PR basicmachines-co/basic-memory#2057, which removes note formatting (breaking change).
Important
Merge only after basicmachines-co/basic-memory#2057 ships. Until then these settings and
bm formatstill exist in released versions.Changes
content/11.reference/6.configuration.md): remove the Formatter settings section (format_on_save,formatter_command,formatter_timeout, and the mentions offormatters, mdformat, and Prettier).content/11.reference/1.cli-reference.md): remove thebm formatsection.content/07.local/3.cli-basics.md): remove the Format files section.content/02.whats-new/06.changelog.md): add the removal to the 1.0 breaking-changes line.content/11.reference/7.migrating-to-1-0.md): add a short "Note formatting is removed" section: old config keys are ignored, not rejected, and users who want formatting can run their own formatter over the project folder.No version bump and no new What's New page, since the release hasn't shipped.
Not changed
docs/review-findings.md(internal audit log, not published) still mentions the formatter settings in already-resolved findings. Left as history.Verification
npm run buildsucceeds.git grepfinds no remaining mentions undercontent/outside the two breaking-change notes.🤖 Generated with Claude Code
https://claude.ai/code/session_01CMYVKyv6fNv5MUtAeTDALb