fix: emit Windows batch launchers with CRLF line endings - #393
Merged
p0deje merged 1 commit intoAug 5, 2026
Conversation
p0deje
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
rb_binary/rb_testintermittently failed withThe system cannot find the batch label specified - rlocation, breaking runfiles lookups (rlocation,require 'bazel/runfiles'). Linux and macOS were unaffected..cmdlauncher is LF-only, andcmd.exeseeksgoto/call :labeltargets by byte offset — a scan that is unreliable on LF-only files. Failures were non-deterministic (whether a label straddled an internal read-buffer boundary), which is the signature of this bug rather than a code error.Solution
.cmdwith CRLF throughout. It's assembled from two pieces, so both are handled: the*.cmd.tpltemplates are pinned to CRLF via.gitattributes, and the batch code injected from Starlark is normalized to CRLF..gitattributespin isn't dev-only. The same CRLF conversion is applied when the release archive is built, so consumers get the fixed launchers whether they depend on rules_ruby via BCR, an archive, or git.Receipts
Downstream Selenium Windows CI, same target set, with an override onto this branch (SeleniumHQ/selenium@9e400e6):
rb_testtargets fail atrequire 'bazel/runfiles'(non-deterministic across identical targets on one machine).