Repository navigation
Conversation
…ntainer coordinates on macOS
…ard the trait descriptor on iOS
…tyled spans change
…d name a missing placeholder constraint
# Conflicts: # docs/superpowers/specs/2026-10-06-code-editor-design.md # tests/test_highlighting.py
Member
|
I believe these changes have all been incorporated into #7; closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the minor findings parked during the initial review of
CodeEditor, across the interface, the highlighting module, the three native backends, the example app, and the docs.The user-visible changes: construction paints once, with the theme in place first; a failure in the debounced re-highlight reaches the event loop's exception handler at once;
DEFAULT_THEMEis read-only; zero-length spans never reach a backend; macOS reads only plain text from the pasteboard, and Android strips pasted formatting when it re-highlights;toga-coreis bounded below 0.6; and the Android keyboard note now matches what Android 12 and 15 emulators show.Verified by the test suite at 100% coverage and by running the example app on macOS, the iOS 26.3 simulator, and Android 12 and 15 emulators.
PR Checklist:
Assisted-by: Claude Code (Claude Fable 5.1)