Skip to content

test: let the first preview land in the new-query strand tests - #269

Merged
ben-dev-au merged 1 commit into
mainfrom
test/new-query-strand-setup
Nov 11, 2026
Merged

ben-dev-au merged 1 commit into
mainfrom
test/new-query-strand-setup

Conversation

@ben-dev-au

Copy link
Copy Markdown
Owner

#262 moved the parked-mount tests onto first_preview_landed, but missed tests/test_preview_new_query_strand.py. Both of its tests still took over mount_task as soon as results showed. The app's own first decode could then report back and cancel the parked mount before it reached cancel_task_on. That is the macOS CI failure on #267: "the mount never reached its early await".

Both tests now wait for first_preview_landed, like the other parked-mount tests.

  • Negative control: holding the app's decode back (0.1 s off-thread get_file_chunks plus a slow remove_children) fails one or both tests in 3 of 3 runs without this change, with CI's exact message, and passes 3 of 3 with it.
  • Full suite: 6902 passed, 5 skipped; tmux harness 12 of 12.

#262 moved the parked-mount tests onto `first_preview_landed` but missed
this file. Both tests still took over `mount_task` as soon as results
showed, so the app's own first decode could report back and cancel the
parked mount before it reached `cancel_task_on` (macOS CI on #267: "the
mount never reached its early await").

Holding the app's decode back (0.1 s off-thread `get_file_chunks`, slow
`remove_children`) fails one or both tests 3 of 3 runs without this and
passes 3 of 3 with it.
@coderabbitai

coderabbitai Bot commented Nov 11, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 69b1661f-1bf1-40c7-a544-ef1440d830ef
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@ben-dev-au
ben-dev-au merged commit 5f3c5ec into main Nov 11, 2026
22 checks passed
@ben-dev-au
ben-dev-au deleted the test/new-query-strand-setup branch November 11, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant