Repository navigation
test: let the first preview land in the new-query strand tests - #269
Merged
Merged
Conversation
#262 moved the parked-mount tests onto `first_preview_landed` but missed this file. Both tests still took over `mount_task` as soon as results showed, so the app's own first decode could report back and cancel the parked mount before it reached `cancel_task_on` (macOS CI on #267: "the mount never reached its early await"). Holding the app's decode back (0.1 s off-thread `get_file_chunks`, slow `remove_children`) fails one or both tests 3 of 3 runs without this and passes 3 of 3 with it.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#262 moved the parked-mount tests onto
first_preview_landed, but missedtests/test_preview_new_query_strand.py. Both of its tests still took overmount_taskas soon as results showed. The app's own first decode could then report back and cancel the parked mount before it reachedcancel_task_on. That is the macOS CI failure on #267: "the mount never reached its early await".Both tests now wait for
first_preview_landed, like the other parked-mount tests.get_file_chunksplus a slowremove_children) fails one or both tests in 3 of 3 runs without this change, with CI's exact message, and passes 3 of 3 with it.