Read the Job and Project from either dispatch payload shape - #10
Merged
Merged
Conversation
The bare metal attach workflow read the Job and the Project from the `bencher` object of the repository_dispatch payload. Callbacks sent by the current job callbacks branch carry them as top-level `job` and `project` keys instead, so fall back to those when the `bencher` object is absent.
|
Bencher Report| Project | Example |
| Branch | u/ep/bare-metal-attach-compat |
| Testbed | ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|
| bencher::mock_0 | 📈 view plot 🚷 view threshold | 3.10 ns(-38.76%)Baseline: 5.06 ns | 11.54 ns (26.84%) |
| bencher::mock_1 | 📈 view plot 🚷 view threshold | 13.75 ns(-12.85%)Baseline: 15.77 ns | 22.25 ns (61.78%) |
| bencher::mock_2 | 📈 view plot 🚷 view threshold | 20.90 ns(-14.31%)Baseline: 24.40 ns | 31.22 ns (66.97%) |
| bencher::mock_3 | 📈 view plot 🚷 view threshold | 34.24 ns(-1.40%)Baseline: 34.73 ns | 42.46 ns (80.65%) |
| bencher::mock_4 | 📈 view plot 🚷 view threshold | 42.59 ns(-4.01%)Baseline: 44.37 ns | 51.05 ns (83.44%) |
epompeii
marked this pull request as ready for review
September 26, 2026 20:31
|
| Project | Example |
| Branch | fork/u/ep/bare-metal-attach-compat |
| Testbed | ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|
| bencher::mock_0 | 📈 view plot 🚷 view threshold | 1.00 ns(-80.24%)Baseline: 5.06 ns | 11.54 ns (8.66%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bare metal attach workflow reads the Job and the Project from the
bencherobject of therepository_dispatchpayload. Callbacks from the current job callbacks branch send them as top-leveljobandprojectkeys, so both values now fall back to those keys when thebencherobject is absent. Both still pass throughenv:.