Read the Job and Project only from the bencher object - #12
Merged
Merged
Conversation
The job callbacks branch now sends only the two-object dispatch payload, so the fallback to the old top-level job and project keys is no longer needed.
|
| Project | Example |
| Branch | u/ep/bare-metal-attach-payload |
| Testbed | ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|
| bencher::mock_0 | 📈 view plot 🚷 view threshold | 3.34 ns(-32.55%)Baseline: 4.96 ns | 11.52 ns (29.02%) |
| bencher::mock_1 | 📈 view plot 🚷 view threshold | 15.16 ns(-4.43%)Baseline: 15.86 ns | 22.37 ns (67.76%) |
| bencher::mock_2 | 📈 view plot 🚷 view threshold | 22.03 ns(-9.30%)Baseline: 24.29 ns | 31.18 ns (70.67%) |
| bencher::mock_3 | 📈 view plot 🚷 view threshold | 32.56 ns(-6.11%)Baseline: 34.68 ns | 42.32 ns (76.93%) |
| bencher::mock_4 | 📈 view plot 🚷 view threshold | 47.69 ns(+7.54%)Baseline: 44.35 ns | 50.93 ns (93.65%) |
epompeii
marked this pull request as ready for review
September 26, 2026 23:37
|
| Project | Example |
| Branch | fork/u/ep/bare-metal-attach-payload |
| Testbed | ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|
| bencher::mock_0 | 📈 view plot 🚷 view threshold | 1.00 ns(-79.83%)Baseline: 4.96 ns | 11.52 ns (8.68%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The job callbacks branch now sends only the two-object dispatch payload, so the attach workflow reads the Job and the Project from the
bencherobject again and drops the fallback to the old top-leveljobandprojectkeys. This restores the file as it was in #9.