Repository navigation
Conversation
Collaborator
|
Thanks @oxura, but we're closing this one too.
Please don't open another PR that only changes this message or adds to WONTFIX for #1322. A change to the kernel itself, such as a native path for Nat literals, would be welcome. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The kernel already prints
out of fuel, but the CLI then calls it a TypeScript/kernel mismatch. The notice now says the proofs could not be validated, without claiming the two checkers disagreed. It still appears on every rejection.This takes #1322's diagnostic/documentation option: WONTFIX now gives the 400,000,000-step conversion budget and the split-equality workaround. No fuel increase or Nat evaluator change.
Checked on Linux x86_64 with the unchanged Lean 4.34.0 kernel: the 3M comparison still exits 1 with its fuel detail and empty stdout; the paired 1.6M equalities pass; #1623 still rejects with
expected/observed. The real safe worker still classifies the rejection correctly. Repo gate: 54/54.Dropped the old stub assertion that pinned the notice's prose; the update-notice/safe-worker test stays. Full ping gate skipped because the site checkout is absent.
Fixes #1322 (the reporting/documentation option). AI-assisted.