Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two spellings of
IOare easy to swap, and each one reported an error thatnever named the other:
The reverse,
do IO(Unit):, reported onlyexpected '<'/observed '('.IOis a base def, not an ADT, so a type writtenIO<...>fell through to the"unknown datatype" message; and the
doparser expected<without sayingwhat it was for. Both now name the pair and the position:
a type:IO<...>is the do block's effect syntax; a return type is writtenIO(...)``an effect's arguments in<...>(a do block isdo IO<...>:, and the type is writtenIO(...))The two tests pin both messages and exit 1:
tests/check/io_effect_in_return_type.bendtests/parse/do_effect_type_spelling.bendWhat I ran: the source compiler (
bun bend2/main.ts) on both tests (outputmatches the pinned
#|lines),gates/repo.ts --gate(PASS 54/54), and a validIO(Unit)/do IO<Unit>program (printshi).gates/test.tsneeds thecluster and
BEND_HOCis not set here, so I did not run the full test gate; CIwill.