-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Remove unnecessary usage of SystemState API in tests and benchmarks #23238
Copy link
Copy link
Closed
Labels
A-ECSEntities, components, systems, and eventsEntities, components, systems, and eventsC-Code-QualityA section of code that is hard to understand or changeA section of code that is hard to understand or changeC-TestingA change that impacts how we test Bevy or how users test their appsA change that impacts how we test Bevy or how users test their appsD-StraightforwardSimple bug fixes and API improvements, docs, test and examplesSimple bug fixes and API improvements, docs, test and examplesS-Ready-For-ImplementationThis issue is ready for an implementation PR. Go for it!This issue is ready for an implementation PR. Go for it!X-UncontroversialThis work is generally agreed uponThis work is generally agreed upon
Description
Activity
Metadata
Metadata
Assignees
Labels
A-ECSEntities, components, systems, and eventsEntities, components, systems, and eventsC-Code-QualityA section of code that is hard to understand or changeA section of code that is hard to understand or changeC-TestingA change that impacts how we test Bevy or how users test their appsA change that impacts how we test Bevy or how users test their appsD-StraightforwardSimple bug fixes and API improvements, docs, test and examplesSimple bug fixes and API improvements, docs, test and examplesS-Ready-For-ImplementationThis issue is ready for an implementation PR. Go for it!This issue is ready for an implementation PR. Go for it!X-UncontroversialThis work is generally agreed uponThis work is generally agreed upon
Type
Projects
- StatusShow more project fieldsDone
I think that we should instead be pushing users to just call
World::run_systemmore for these sorts of world-splitting use cases. The ergonomics are ultimately always going to be much better, and it's more consistent with other usages.Then: no more internal complexity!
Originally posted by @alice-i-cecile in #23225 (comment)