Make asset loading no longer use the type of the load. - #25664
Open
andriyDev wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fix a bunch of weird edge cases of asset loading:
asset_server.load<Gltf>("whatever.png"), this will try to use theGltfLoadersince we prioritize the asset type not the extension.asset_server.load<Image>("whatever.png")andasset_server.load<Gltf>("whatever.png"), this will actually do two loads, even though one of these loads makes no sense!Solution
I haven't fixed all of the above issues, but this is the first step.
Testing