Revert "Resolve one compositing space per camera stack (#25481)" - #25676
Revert "Resolve one compositing space per camera stack (#25481)"#25676beicause wants to merge 2 commits into
Conversation
)" This reverts commit 8a83227.
|
It isn't just a diagnostic check, and it is needed by a whole stack of PRs both currently open and to come. I'm fine improving it further and/or simplifiying it as time goes on but would rather get the two bug fix PRs in than revert this and break a bunch of the PRs already open |
Actually, I hope we can implement a minimal HDR output MVP first and then make improvements on these smaller issues. |
|
Skipping the rendering pipeline fixes will cause real bugs and real regressions, which I've already spent months working through and addressing. I'm happy to make changes or adjust if you have specific feedback, but I don't think "ship HDR and have lots of things not work" is a good strategy. Also we are pretty close to the actual HDR parts going in, the first of wave 3 is already up for review and the two after it are ready to go once it merges. |
This reverts commit 8a83227 (#25481).
Objective
There is currently minor bugs in the camera stack resolution. Although it could be fixed by #25646 and #25661, I still have some reasons to want to revert it for now:
MainTextureKey. The current special‑case code is somewhat fragile and complicated.cc @stuartparmenter
Solution
Revert it.
Testing
CI