Skip to content

Fix: outerHTML swap with body fragment corrupts non-body targets #3983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1cg merged 2 commits into from
Aug 28, 2026
Merged

Fix: outerHTML swap with body fragment corrupts non-body targets #3983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce6eb12
Fix: outerHTML swap with body fragment corrupts non-body targets
MichaelWest22 Aug 28, 2026
425a218
fix after rebase
MichaelWest22 Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/htmx.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1347,10 +1347,11 @@ var htmx = (() => {
}
let swapStyle = swapSpec.style;
if (swapStyle === 'none') return;
// full-page response: fragment has a <body> wrapper, so upgrade outerHTML to outerSync, strip for everything else
// Body fragment: strip wrapper unless outer* swap on document.body
if (fragment.firstElementChild?.tagName === 'BODY') {
if (swapStyle === 'outerHTML') swapStyle = 'outerSync';
else if (!swapStyle.startsWith('outer')) swapSpec.strip = true;
const keepBody = target === document.body && swapStyle.startsWith('outer')
if (keepBody && swapStyle === 'outerHTML') swapStyle = 'outerSync'
swapSpec.strip ??= !keepBody
}
if (swapSpec.strip && fragment.firstElementChild) {
fragment = document.createDocumentFragment();
Expand Down
36 changes: 36 additions & 0 deletions test/tests/attributes/hx-swap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,4 +95,40 @@ describe('hx-swap modifiers', function() {
assert.equal(find('#target').className, 'test')
assert.equal(find('#target').textContent, 'New Text')
})

it('outerHTML with body fragment on non-body target strips body wrapper', async function () {
mockResponse('GET', '/test', '<body class="from-response"><p>New content</p></body>')
createProcessedHTML('<button id="btn" hx-get="/test" hx-target="#target" hx-swap="outerHTML">Get</button><div id="target" class="original">Old</div>');
find('#btn').click()
await forRequest()
// Target should be replaced by <p>, body wrapper stripped
assert.isUndefined(find('#target'), 'Target should be replaced')
let p = find('p')
assert.exists(p)
assert.equal(p.textContent, 'New content')
assert.equal(p.parentElement.id, 'test-playground')
})

it('outerHTML with full HTML document on non-body target strips body wrapper', async function () {
mockResponse('GET', '/test', '<!DOCTYPE html><html><head><title>Page</title></head><body class="page"><div class="content">Content</div></body></html>')
createProcessedHTML('<button id="btn" hx-get="/test" hx-target="#target" hx-swap="outerHTML">Get</button><div id="target" class="widget">Widget</div>');
find('#btn').click()
await forRequest()
assert.isUndefined(find('#target'), 'Target should be replaced')
let content = find('.content')
assert.exists(content)
assert.equal(content.parentElement.id, 'test-playground')
})

it('innerHTML with body fragment strips body wrapper', async function () {
mockResponse('GET', '/test', '<body class="ignored"><span>A</span><span>B</span></body>')
createProcessedHTML('<button id="btn" hx-get="/test" hx-target="#target" hx-swap="innerHTML">Get</button><div id="target" class="keep-me">Old</div>');
find('#btn').click()
await forRequest()
let target = find('#target')
assert.exists(target)
assert.equal(target.className, 'keep-me', 'Target keeps its attributes')
assert.equal(target.children.length, 2)
assert.equal(target.children[0].tagName, 'SPAN')
})
})
Loading