Track generated dist/*.d.ts alongside the other artifacts - #159
Merged
Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
myabc
changed the title
dist/*.d.ts alongside the other artifacts
The only artifact `npm run dist` produces that was never added to git, so it sat untracked and dirtied the working tree after every build. Generated from dist/*.esm.js rather than src/, so these move in lockstep with the artifacts already committed, and add no churn outside the release commit.
myabc
force-pushed
the
fix/track-generated-dts
branch
from
August 26, 2026 01:52
abd4a04 to
d073b74
Compare
Contributor
Author
|
@botandrose In line with your comment on build artifacts, I didn't end up committing any files in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Missed as part of #153.
Running the build leaves
dist/idiomorph.d.tsanddist/idiomorph-ext.d.tspermanently untracked, sogit statusis never clean afterwards:They are the only thing
npm run distproduces that was never added to git. Nothing ignores them either, so they just sit there as noise. This adds both files.Tracking them because they are generated from
dist/*.esm.jsrather than fromsrc/means they move in lockstep with the artifacts already committed. They add no churn outside the release commit, which already touches all ofdist/. It also keeps types working for anyone installing straight from the repository, sincepackage.jsonpoints"types"atdist/idiomorph.d.ts.The alternative was
dist/*.d.tsin.gitignore. I checked that would not break publishing because thefilesallow-list wins over.gitignore, sonpm packstill includes both. This splitsdist/into some artifacts tracked and some ignored. I will switch if you would rather not carry the files.