Repository navigation
Preserve decimal margin borrow amounts - #253
Open
JMak-Security wants to merge 1 commit into
Open
JMak-Security wants to merge 1 commit into
JMak-Security wants to merge 1 commit into
Conversation
Fixes binance#221 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MarginAccountNewOrderResponse.marginBuyBorrowAmountwas generated as aLong, so Gson could not deserialize fractional borrow amounts such as0.001. Change the property, fluent setter, getter, and setter toString, matching the decimal representation and the corresponding OCO response model. Update the generated model documentation as well.This changes the public Java accessor type from
LongtoString; callers should treat the amount as a decimal string to preserve its exact value and scale.Validation
mvn -f clients/margin-trading/pom.xml test— all 69 module tests passed.0.00100), null, and missing values.Fixes #221.